Deprecate and remove unused PPB_Flash functions.

Deprecate and remove unused PPB_Flash functions.

There are a number of functions in PPB_Flash which have been unused for some time. These are:
RunMessageLoop/QuitMessageLoop - Deprecated in M18
GetSettingInt - Deprecated in M21
GetDeviceID - Deprecated in M21
InvokePrinting - Deprecated in M21

This change removes the implementations of those functions so that they do not have to be implemented in the new proxy. It also marks them as deprecated in PPB_Flash for version 13.0.

The change also removes PPB_Flash interfaces which are <12.4 because they are pre-M21.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169516

[yzshen1, 2012-11-20 21:01:25]

only a few nits. Thanks. :)

https://codereview.chromium.org/11411102/diff/8001/ppapi/tests/test_flash.cc
File ppapi/tests/test_flash.cc (right):

https://codereview.chromium.org/11411102/diff/8001/ppapi/tests/test_flash.cc#...
ppapi/tests/test_flash.cc:99: Var result =
Flash::GetSetting(pp::InstanceHandle(PP_Instance(0)),
PP_Instance(0) is actually a C-style conversion. Please use C++-style.

https://codereview.chromium.org/11411102/diff/8001/ppapi/tests/test_flash.h
File ppapi/tests/test_flash.h (right):

https://codereview.chromium.org/11411102/diff/8001/ppapi/tests/test_flash.h#n...
ppapi/tests/test_flash.h:11: #include "ppapi/c/private/ppb_flash.h"
nit: This is not needed.

https://codereview.chromium.org/11411102/diff/8001/ppapi/thunk/ppb_flash_thun...
File ppapi/thunk/ppb_flash_thunk.cc (right):

https://codereview.chromium.org/11411102/diff/8001/ppapi/thunk/ppb_flash_thun...
ppapi/thunk/ppb_flash_thunk.cc:78: NOTREACHED();
nit: Please include base/logging.h.

https://codereview.chromium.org/11411102/diff/8001/ppapi/thunk/ppb_flash_thun...
ppapi/thunk/ppb_flash_thunk.cc:136: return PP_ERROR_NOTSUPPORTED;
Please use -1 as the previous implementation. This is not a PPAPI error result
code.

https://codereview.chromium.org/11411102/diff/8001/ppapi/thunk/ppb_widget_thu...
File ppapi/thunk/ppb_widget_thunk.cc (left):

https://codereview.chromium.org/11411102/diff/8001/ppapi/thunk/ppb_widget_thu...
ppapi/thunk/ppb_widget_thunk.cc:5: // From dev/ppb_widget_dev.idl modified Fri
Nov 16 11:26:06 2012.
Why this is changed?

https://codereview.chromium.org/11411102/diff/8001/webkit/plugins/ppapi/ppb_f...
File webkit/plugins/ppapi/ppb_flash_impl.cc (right):

https://codereview.chromium.org/11411102/diff/8001/webkit/plugins/ppapi/ppb_f...
webkit/plugins/ppapi/ppb_flash_impl.cc:10: #include "base/message_loop.h"
No need to include this?

[raymes, 2012-11-20 23:40:32]

https://codereview.chromium.org/11411102/diff/8001/ppapi/tests/test_flash.cc
File ppapi/tests/test_flash.cc (right):

https://codereview.chromium.org/11411102/diff/8001/ppapi/tests/test_flash.cc#...
ppapi/tests/test_flash.cc:99: Var result =
Flash::GetSetting(pp::InstanceHandle(PP_Instance(0)),
On 2012/11/20 21:01:26, yzshen1 wrote:
> PP_Instance(0) is actually a C-style conversion. Please use C++-style.

True. I was thinking of it as a constructor. Done.

https://codereview.chromium.org/11411102/diff/8001/ppapi/thunk/ppb_flash_thun...
File ppapi/thunk/ppb_flash_thunk.cc (right):

https://codereview.chromium.org/11411102/diff/8001/ppapi/thunk/ppb_flash_thun...
ppapi/thunk/ppb_flash_thunk.cc:78: NOTREACHED();
On 2012/11/20 21:01:26, yzshen1 wrote:
> nit: Please include base/logging.h.

Done.

https://codereview.chromium.org/11411102/diff/8001/ppapi/thunk/ppb_flash_thun...
ppapi/thunk/ppb_flash_thunk.cc:136: return PP_ERROR_NOTSUPPORTED;
On 2012/11/20 21:01:26, yzshen1 wrote:
> Please use -1 as the previous implementation. This is not a PPAPI error result
> code.

Done.

https://codereview.chromium.org/11411102/diff/8001/ppapi/thunk/ppb_widget_thu...
File ppapi/thunk/ppb_widget_thunk.cc (left):

https://codereview.chromium.org/11411102/diff/8001/ppapi/thunk/ppb_widget_thu...
ppapi/thunk/ppb_widget_thunk.cc:5: // From dev/ppb_widget_dev.idl modified Fri
Nov 16 11:26:06 2012.
On 2012/11/20 21:01:26, yzshen1 wrote:
> Why this is changed?

I'm not sure. generator.py decided to update it. I'll exclude it...

https://codereview.chromium.org/11411102/diff/8001/webkit/plugins/ppapi/ppb_f...
File webkit/plugins/ppapi/ppb_flash_impl.cc (right):

https://codereview.chromium.org/11411102/diff/8001/webkit/plugins/ppapi/ppb_f...
webkit/plugins/ppapi/ppb_flash_impl.cc:10: #include "base/message_loop.h"
On 2012/11/20 21:01:26, yzshen1 wrote:
> No need to include this?

Done.

[raymes, 2012-11-26 18:27:51]

+brettw since yzshen is out

[brettw, 2012-11-26 19:18:32]

LGTM, we should be sure to roll this into Flash so we can start the deprecation
timer for 12.*

[commit-bot: I haz the power, 2012-11-26 19:22:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/11411102/6010

[commit-bot: I haz the power, 2012-11-26 19:22:35]

Presubmit check for 11411102-6010 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ppapi/proxy/ppapi_messages.h
    content/common/pepper_messages.h

Presubmit checks took 3.3s to calculate.

[raymes, 2012-11-26 19:29:36]

+tsepez for IPC messages. Only removal of IPCs so this should be easy

[Tom Sepez, 2012-11-26 19:34:32]

LGTM for messages.

[commit-bot: I haz the power, 2012-11-26 20:27:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/11411102/6010

[commit-bot: I haz the power, 2012-11-26 22:42:07]

Change committed as 169516