Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 11411071: chromeos: Remove GViewRequestInterceptor. (Closed)

Created:
8 years, 1 month ago by Daniel Erat
Modified:
8 years ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Remove GViewRequestInterceptor. This removes the code for sending the user to GView for PDF and .ppt files. The --enable-gview flag has been passed unconditionally on Chrome OS for a long time, but we ignore it in official builds. For Chromium OS, I believe that https://chrome.google.com/webstore/detail/docs-pdfpowerpoint-viewer/nnbmlagghjjcbdhgmkedmbmedengocbn provides similar functionality. BUG=161786 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170875

Patch Set 1 #

Patch Set 2 : make GViewRequestInterceptor skip failed requests #

Patch Set 3 : delete GViewRequestInterceptor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -530 lines) Patch
D chrome/browser/chromeos/gview_request_interceptor.h View 1 2 1 chunk +0 lines, -55 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor.cc View 1 2 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/browser/chromeos/gview_request_interceptor_unittest.cc View 1 2 1 chunk +0 lines, -297 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/profile_startup.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 2 2 chunks +0 lines, -29 lines 0 comments Download
M tools/heapcheck/unit_tests.gtest-heapcheck.txt View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M tools/valgrind/gtest_exclude/unit_tests.gtest_linux.txt View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Daniel Erat
8 years, 1 month ago (2012-11-19 17:21:14 UTC) #1
zel
lgtm
8 years, 1 month ago (2012-11-19 17:31:16 UTC) #2
willchan no longer on Chromium
chrome/browser/profiles LGTM
8 years, 1 month ago (2012-11-19 17:31:41 UTC) #3
Ben Goodger (Google)
lgtm
8 years, 1 month ago (2012-11-19 17:35:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/11411071/1
8 years, 1 month ago (2012-11-19 19:27:05 UTC) #5
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 1 month ago (2012-11-19 22:00:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/11411071/1
8 years, 1 month ago (2012-11-19 22:06:06 UTC) #7
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 1 month ago (2012-11-20 00:43:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/11411071/1
8 years, 1 month ago (2012-11-20 02:49:25 UTC) #9
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 1 month ago (2012-11-20 05:10:31 UTC) #10
Daniel Erat
On 2012/11/20 05:10:31, I haz the power (commit-bot) wrote: > Retried try job too often ...
8 years, 1 month ago (2012-11-21 00:56:53 UTC) #11
Daniel Erat
Another look? I'm just deleting GViewRequestInterceptor now.
8 years ago (2012-12-03 23:55:39 UTC) #12
willchan no longer on Chromium
profiles/ lgtm still
8 years ago (2012-12-04 00:20:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/11411071/16001
8 years ago (2012-12-04 00:43:18 UTC) #14
commit-bot: I haz the power
8 years ago (2012-12-04 03:55:38 UTC) #15
Message was sent while issue was closed.
Change committed as 170875

Powered by Google App Engine
This is Rietveld 408576698