Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(889)

Issue 11411065: Fix --hydrogen-stats. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix --hydrogen-stats. Timing happens in a scope. Since crankshaft has been chopped up into three methods, this approach is wrong. BUG= Committed: https://code.google.com/p/v8/source/detail?r=12998

Patch Set 1 #

Patch Set 2 : dumdidum #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -27 lines) Patch
M src/compiler.cc View 1 4 chunks +17 lines, -10 lines 0 comments Download
M src/hydrogen.h View 1 3 chunks +14 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 1 2 chunks +27 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
PTAL.
5 years, 5 months ago (2012-11-19 13:02:33 UTC) #1
Jakob Kummerow
LGTM
5 years, 5 months ago (2012-11-19 13:33:03 UTC) #2
Jakob Kummerow
5 years, 5 months ago (2012-11-19 14:20:02 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698