Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 11411049: Enable Android APKs to be build with R.java in a custom package. (Closed)

Created:
8 years, 1 month ago by newt (away)
Modified:
8 years, 1 month ago
Reviewers:
cjhopman, Yaron
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, shashi
Visibility:
Public.

Description

Enable Android APKs to be build with R.java in a custom package. BUG=158558 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
A build/android/ant/empty/res/.keep View 1 chunk +2 lines, -0 lines 0 comments Download
M build/java_apk.gypi View 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
newt (away)
PTAL
8 years, 1 month ago (2012-11-16 23:55:11 UTC) #1
cjhopman
lgtm
8 years, 1 month ago (2012-11-19 18:22:56 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 1 month ago (2012-11-19 18:24:44 UTC) #3
newt (away)
Yaron, could you take a look? Thanks!
8 years, 1 month ago (2012-11-19 18:26:24 UTC) #4
Yaron
Do you have a sample client usage of this change? It's not clear to me ...
8 years, 1 month ago (2012-11-19 18:34:29 UTC) #5
Yaron
lgtm
8 years, 1 month ago (2012-11-20 00:10:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/11411049/1
8 years, 1 month ago (2012-11-20 00:15:53 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-11-20 02:17:25 UTC) #8
Change committed as 168704

Powered by Google App Engine
This is Rietveld 408576698