Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11411005: Rename SeqAsciiString (Closed)

Created:
8 years, 1 month ago by drcarney
Modified:
8 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Rename SeqAsciiString This is a straight rename: NewRawAsciiString -> NewRawOneByteString SeqAscii -> SeqOneByte SeqOneByteString cannot yet take non-ascii data. R=yangguo@chromium.org, BUG= Committed: https://code.google.com/p/v8/source/detail?r=12972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -268 lines) Patch
M src/arm/code-stubs-arm.cc View 10 chunks +15 lines, -15 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 7 chunks +15 lines, -9 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/bootstrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/heap.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/heap.cc View 12 chunks +19 lines, -19 lines 0 comments Download
M src/heap-inl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 12 chunks +19 lines, -19 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/json-parser.h View 11 chunks +14 lines, -14 lines 0 comments Download
M src/json-stringifier.h View 5 chunks +6 lines, -6 lines 0 comments Download
M src/liveobjectlist.cc View 1 chunk +1 line, -1 line 0 comments Download
src/mips/code-stubs-mips.cc View 10 chunks +15 lines, -15 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 7 chunks +13 lines, -13 lines 0 comments Download
M src/objects.cc View 15 chunks +22 lines, -21 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects-inl.h View 7 chunks +11 lines, -11 lines 0 comments Download
M src/objects-visiting.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects-visiting.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-visiting-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/regexp-macro-assembler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 17 chunks +22 lines, -22 lines 0 comments Download
M src/v8conversions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 12 chunks +19 lines, -19 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-regexp.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M tools/gen-postmortem-metadata.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Yang
8 years, 1 month ago (2012-11-15 13:27:50 UTC) #1 
LGTM. Landing.

Powered by Google App Engine
This is Rietveld 408576698