Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: chrome/browser/chromeos/login/version_info_updater.cc

Issue 11410073: Add function to CancelableTaskTracker and convert BootTimeLoader (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase again and add tests Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/version_info_updater.h ('k') | chrome/common/cancelable_task_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/version_info_updater.cc
diff --git a/chrome/browser/chromeos/login/version_info_updater.cc b/chrome/browser/chromeos/login/version_info_updater.cc
index 2c9ccc5b4160a140126e60164f4ce84f41a29e38..42aa2e4f58192405b9b46a0ffb4ae77e184284b3 100644
--- a/chrome/browser/chromeos/login/version_info_updater.cc
+++ b/chrome/browser/chromeos/login/version_info_updater.cc
@@ -59,10 +59,10 @@ void VersionInfoUpdater::StartUpdate(bool is_official_build) {
base::Bind(&VersionInfoUpdater::OnVersion, base::Unretained(this)),
&tracker_);
boot_times_loader_.GetBootTimes(
- &boot_times_consumer_,
- base::Bind(is_official_build ? &VersionInfoUpdater::OnBootTimesNoop :
- &VersionInfoUpdater::OnBootTimes,
- base::Unretained(this)));
+ base::Bind(is_official_build ? &VersionInfoUpdater::OnBootTimesNoop
+ : &VersionInfoUpdater::OnBootTimes,
+ base::Unretained(this)),
+ &tracker_);
} else {
UpdateVersionLabel();
}
@@ -195,11 +195,10 @@ void VersionInfoUpdater::OnVersion(const std::string& version) {
}
void VersionInfoUpdater::OnBootTimesNoop(
- BootTimesLoader::Handle handle, BootTimesLoader::BootTimes boot_times) {
-}
+ const BootTimesLoader::BootTimes& boot_times) {}
void VersionInfoUpdater::OnBootTimes(
- BootTimesLoader::Handle handle, BootTimesLoader::BootTimes boot_times) {
+ const BootTimesLoader::BootTimes& boot_times) {
const char* kBootTimesNoChromeExec =
"Non-firmware boot took %.2f seconds (kernel %.2fs, system %.2fs)";
const char* kBootTimesChromeExec =
« no previous file with comments | « chrome/browser/chromeos/login/version_info_updater.h ('k') | chrome/common/cancelable_task_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698