Issue 11410073: Add function to CancelableTaskTracker and convert BootTimeLoader

Issue 11410073: Add function to CancelableTaskTracker and convert BootTimeLoader (Closed)

Created:
8 years, 1 month ago by kaiwang

Modified:
8 years, 1 month ago

Reviewers:
brettw

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, akalin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add function to CancelableTaskTracker and convert BootTimeLoader BUG=155883 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168134

Patch Set 2 : Fix compiling error #

Patch Set 4 : Rebase and address comment #

Patch Set 5 : Rebase again and add tests #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+177 lines, -50 lines)			Patch
M	chrome/browser/chromeos/boot_times_loader.h	View	1 2	4 chunks	+14 lines, -18 lines	0 comments	Download
M	chrome/browser/chromeos/boot_times_loader.cc	View	1 2 3	7 chunks	+35 lines, -17 lines	0 comments	Download
M	chrome/browser/chromeos/login/version_info_updater.h	View	1 2 3 4	1 chunk	+5 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/version_info_updater.cc	View	1 2 3 4	2 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/common/cancelable_task_tracker.h	View		3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/common/cancelable_task_tracker.cc	View		3 chunks	+36 lines, -0 lines	0 comments	Download
M	chrome/common/cancelable_task_tracker_unittest.cc	View	1 2 3 4	5 chunks	+69 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

brettw

Hope I followed everything. I think this approach makes sense. LGTM http://codereview.chromium.org/11410073/diff/6014/chrome/browser/chromeos/boot_times_loader.cc File chrome/browser/chromeos/boot_times_loader.cc (right): ...

8 years, 1 month ago (2012-11-15 23:40:07 UTC) #3

kaiwang

http://codereview.chromium.org/11410073/diff/6014/chrome/browser/chromeos/boot_times_loader.cc File chrome/browser/chromeos/boot_times_loader.cc (right): http://codereview.chromium.org/11410073/diff/6014/chrome/browser/chromeos/boot_times_loader.cc#newcode83 chrome/browser/chromeos/boot_times_loader.cc:83: } On 2012/11/15 23:40:07, brettw wrote: > Since you're ...

8 years, 1 month ago (2012-11-16 00:26:20 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/11410073/15002

8 years, 1 month ago (2012-11-16 01:29:58 UTC) #5

kinuko

8 years, 1 month ago (2012-11-16 06:16:18 UTC) #7

CancelableTaskTrackerTest.CheckTrackedTaskIdOnDifferentThread seems to be flaky
because it's hitting assertion error:

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...

Expand Messages | Collapse Messages