Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 11410040: Delete WebUI for web intents. (Closed)

Created:
8 years, 1 month ago by Greg Billock
Modified:
8 years, 1 month ago
Reviewers:
James Hawkins
CC:
chromium-reviews, dbeam+watch-options_chromium.org, groby+watch_chromium.org, arv (Not doing code reviews), gbillock+watch_chromium.org, smckay+watch_chromium.org, rouslan+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Return value from flag for profile disablement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -805 lines) Patch
M chrome/browser/intents/web_intents_registry.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/intents/web_intents_util.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/resources/options/content_settings.html View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/resources/options/content_settings.js View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/ui/intents/web_intents_model.h View 1 chunk +0 lines, -138 lines 0 comments Download
D chrome/browser/ui/intents/web_intents_model.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D chrome/browser/ui/intents/web_intents_model_unittest.cc View 1 chunk +0 lines, -215 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/ui/webui/options/web_intents_settings_handler.h View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/ui/webui/options/web_intents_settings_handler.cc View 1 chunk +0 lines, -164 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Greg Billock
8 years, 1 month ago (2012-11-12 18:44:28 UTC) #1
James Hawkins
lgtm
8 years, 1 month ago (2012-11-12 18:57:40 UTC) #2
Greg Billock
On 2012/11/12 18:57:40, James Hawkins wrote: > lgtm Changed web_intents_util to return the flag value ...
8 years, 1 month ago (2012-11-15 18:30:32 UTC) #3
James Hawkins
lgtm
8 years, 1 month ago (2012-11-15 18:31:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/11410040/8002
8 years, 1 month ago (2012-11-15 21:54:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/11410040/8002
8 years, 1 month ago (2012-11-16 21:50:33 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-17 02:35:37 UTC) #7
Change committed as 168357

Powered by Google App Engine
This is Rietveld 408576698