Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 11390004: Don't post tasks with unretained this pointer. (Closed)

Created:
8 years, 1 month ago by MAD
Modified:
8 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Don't post tasks with unretained this pointer. BUG=156878 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167182

Patch Set 1 #

Patch Set 2 : Delayed restart et al. #

Total comments: 4

Patch Set 3 : grt's nits addressed... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -34 lines) Patch
M chrome/browser/ui/webui/set_as_default_browser_ui.cc View 1 2 6 chunks +31 lines, -34 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
MAD
Like this?
8 years, 1 month ago (2012-11-07 22:01:25 UTC) #1
motek.
On 2012/11/07 22:01:25, MAD wrote: > Like this? Not quite. Now this is a race ...
8 years, 1 month ago (2012-11-07 22:10:36 UTC) #2
MAD
Got it... Will do when I get to the office... On Wed, Nov 7, 2012 ...
8 years, 1 month ago (2012-11-08 12:44:03 UTC) #3
MAD
OK, how about this then?
8 years, 1 month ago (2012-11-08 14:30:54 UTC) #4
grt (UTC plus 2)
lgtm with a pair of nits. marcin? https://codereview.chromium.org/11390004/diff/10001/chrome/browser/ui/webui/set_as_default_browser_ui.cc File chrome/browser/ui/webui/set_as_default_browser_ui.cc (right): https://codereview.chromium.org/11390004/diff/10001/chrome/browser/ui/webui/set_as_default_browser_ui.cc#newcode360 chrome/browser/ui/webui/set_as_default_browser_ui.cc:360: void SetAsDefaultBrowserDialogImpl::ResetSentinelOnFileThread() ...
8 years, 1 month ago (2012-11-08 15:11:27 UTC) #5
MAD
Thanks Greg... https://codereview.chromium.org/11390004/diff/10001/chrome/browser/ui/webui/set_as_default_browser_ui.cc File chrome/browser/ui/webui/set_as_default_browser_ui.cc (right): https://codereview.chromium.org/11390004/diff/10001/chrome/browser/ui/webui/set_as_default_browser_ui.cc#newcode360 chrome/browser/ui/webui/set_as_default_browser_ui.cc:360: void SetAsDefaultBrowserDialogImpl::ResetSentinelOnFileThread() { On 2012/11/08 15:11:27, grt ...
8 years, 1 month ago (2012-11-08 15:19:33 UTC) #6
motek.
lgtm
8 years, 1 month ago (2012-11-08 16:30:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/11390004/3003
8 years, 1 month ago (2012-11-08 16:36:46 UTC) #8
commit-bot: I haz the power
Presubmit check for 11390004-3003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-11-08 16:36:50 UTC) #9
MAD
Oups... forgot about OWNERS review... estade@?
8 years, 1 month ago (2012-11-08 16:47:47 UTC) #10
Evan Stade
lgtm
8 years, 1 month ago (2012-11-08 17:29:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/11390004/3003
8 years, 1 month ago (2012-11-08 18:08:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/11390004/3003
8 years, 1 month ago (2012-11-12 16:17:17 UTC) #13
commit-bot: I haz the power
8 years, 1 month ago (2012-11-12 16:19:50 UTC) #14
Change committed as 167182

Powered by Google App Engine
This is Rietveld 408576698