Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: scripts/master/factory/commands.py

Issue 11379003: Add Windows ASAN bots. (Closed) Base URL: http://git.chromium.org/chromium/tools/build.git@neuter
Patch Set: Add CHROME_ALLOCATOR environment var to tests Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/master/factory/commands.py
diff --git a/scripts/master/factory/commands.py b/scripts/master/factory/commands.py
index a8f36a180bd2362e423ea34a170e1f396ac0234a..09277dec97addcdd882faddcd0f0babb0f54b24e 100644
--- a/scripts/master/factory/commands.py
+++ b/scripts/master/factory/commands.py
@@ -563,6 +563,8 @@ class FactoryCommands(object):
if sharding_args:
cmd.extend(['--sharding-args', sharding_args])
+ env = factory_properties.get('testing_env')
+
cmd.append(self.GetExecutableName(test_name))
arg_list.append('--gtest_print_time')
@@ -571,7 +573,7 @@ class FactoryCommands(object):
self.AddTestStep(chromium_step.AnnotatedCommand, test_name,
ListProperties(cmd), description, do_step_if=doStep,
- br_do_step_if=brDoStep, hide_step_if=hideStep,
+ env=env, br_do_step_if=brDoStep, hide_step_if=hideStep,
target=self._target, factory_properties=factory_properties)
def AddBuildStep(self, factory_properties, name='build', env=None,

Powered by Google App Engine
This is Rietveld 408576698