Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 11378004: Remove DirectRenderer::disableScissorTest, always leave GL_SCISSOR_TEST enabled in GlRenderer (Closed)

Created:
8 years, 1 month ago by jamesr
Modified:
8 years, 1 month ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, danakj, shawnsingh
Visibility:
Public.

Description

Remove DirectRenderer::disableScissorTest, always leave GL_SCISSOR_TEST enabled in GlRenderer Constantly calling glEnable(GL_SCISSOR_TEST) costs us a few ms/frame on some hardware. As it turns out, we never disable the scissor test so we can just leave it on all the time. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166632

Patch Set 1 #

Total comments: 1

Patch Set 2 : enableSci.. -> setSci... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M cc/direct_renderer.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/direct_renderer.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/gl_renderer.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/gl_renderer.cc View 1 3 chunks +2 lines, -8 lines 0 comments Download
M cc/software_renderer.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/software_renderer.cc View 1 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
Seems to be worth a couple ms on a galaxy nexus on one test I'm ...
8 years, 1 month ago (2012-11-08 02:53:52 UTC) #1
danakj
fancy! naming bikeshed question. https://codereview.chromium.org/11378004/diff/1/cc/gl_renderer.cc File cc/gl_renderer.cc (right): https://codereview.chromium.org/11378004/diff/1/cc/gl_renderer.cc#newcode1353 cc/gl_renderer.cc:1353: void GLRenderer::enableScissorTestRect(const gfx::Rect& scissorRect) should ...
8 years, 1 month ago (2012-11-08 02:56:01 UTC) #2
jamesr
On 2012/11/08 02:56:01, danakj wrote: > fancy! naming bikeshed question. > > https://codereview.chromium.org/11378004/diff/1/cc/gl_renderer.cc > File ...
8 years, 1 month ago (2012-11-08 03:08:57 UTC) #3
danakj
lgtm! yay removing dead code.
8 years, 1 month ago (2012-11-08 03:19:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11378004/5001
8 years, 1 month ago (2012-11-08 03:21:28 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-08 07:46:54 UTC) #6
Change committed as 166632

Powered by Google App Engine
This is Rietveld 408576698