Remove DirectRenderer::disableScissorTest, always leave GL_SCISSOR_TEST enabled in GlRenderer

Remove DirectRenderer::disableScissorTest, always leave GL_SCISSOR_TEST enabled in GlRenderer

Constantly calling glEnable(GL_SCISSOR_TEST) costs us a few ms/frame on some hardware.
As it turns out, we never disable the scissor test so we can just leave it on all the
time.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166632

[jamesr, 2012-11-08 02:53:52]

Seems to be worth a couple ms on a galaxy nexus on one test I'm looking at.

[danakj, 2012-11-08 02:56:01]

fancy! naming bikeshed question.

https://codereview.chromium.org/11378004/diff/1/cc/gl_renderer.cc
File cc/gl_renderer.cc (right):

https://codereview.chromium.org/11378004/diff/1/cc/gl_renderer.cc#newcode1353
cc/gl_renderer.cc:1353: void GLRenderer::enableScissorTestRect(const gfx::Rect&
scissorRect)
should this rename to setScissorTestRect then?

[jamesr, 2012-11-08 03:08:57]

On 2012/11/08 02:56:01, danakj wrote:
> fancy! naming bikeshed question.
> 
> https://codereview.chromium.org/11378004/diff/1/cc/gl_renderer.cc
> File cc/gl_renderer.cc (right):
> 
> https://codereview.chromium.org/11378004/diff/1/cc/gl_renderer.cc#newcode1353
> cc/gl_renderer.cc:1353: void GLRenderer::enableScissorTestRect(const
gfx::Rect&
> scissorRect)
> should this rename to setScissorTestRect then?

Yes, definitely! PTAL

[danakj, 2012-11-08 03:19:21]

lgtm! yay removing dead code.

[commit-bot: I haz the power, 2012-11-08 03:21:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/11378004/5001

[commit-bot: I haz the power, 2012-11-08 07:46:54]

Change committed as 166632