Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 11377169: Ensure a transient entry is discarded on in-page navigations. (Closed)

Created:
8 years, 1 month ago by Charlie Reis
Modified:
8 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Ensure a transient entry is discarded on in-page navigations. BUG=160803 TEST=See bug for repro steps. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167856

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M content/browser/web_contents/navigation_controller_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/web_contents/navigation_controller_impl_unittest.cc View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Brett, can you take a look? We weren't clearing the transient entry in RendererDidNavigateInPage, which ...
8 years, 1 month ago (2012-11-14 21:41:53 UTC) #1
brettw
lgtm
8 years, 1 month ago (2012-11-15 00:37:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/11377169/1
8 years, 1 month ago (2012-11-15 00:45:22 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-15 04:39:50 UTC) #4
Change committed as 167856

Powered by Google App Engine
This is Rietveld 408576698