Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Side by Side Diff: src/isolate.cc

Issue 11377158: Fire 'stack' getter of error objects after GC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap-inl.h ('k') | src/list.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 616 matching lines...) Expand 10 before | Expand all | Expand 10 after
627 Handle<Smi> offset(Smi::FromInt(frames[i].offset())); 627 Handle<Smi> offset(Smi::FromInt(frames[i].offset()));
628 elements->set(cursor++, *recv); 628 elements->set(cursor++, *recv);
629 elements->set(cursor++, *fun); 629 elements->set(cursor++, *fun);
630 elements->set(cursor++, *code); 630 elements->set(cursor++, *code);
631 elements->set(cursor++, *offset); 631 elements->set(cursor++, *offset);
632 } 632 }
633 } 633 }
634 } 634 }
635 Handle<JSArray> result = factory()->NewJSArrayWithElements(elements); 635 Handle<JSArray> result = factory()->NewJSArrayWithElements(elements);
636 result->set_length(Smi::FromInt(cursor)); 636 result->set_length(Smi::FromInt(cursor));
637 heap()->error_object_list()->Add(*error_object);
637 return result; 638 return result;
638 } 639 }
639 640
640 641
641 void Isolate::CaptureAndSetDetailedStackTrace(Handle<JSObject> error_object) { 642 void Isolate::CaptureAndSetDetailedStackTrace(Handle<JSObject> error_object) {
642 if (capture_stack_trace_for_uncaught_exceptions_) { 643 if (capture_stack_trace_for_uncaught_exceptions_) {
643 // Capture stack trace for a detailed exception message. 644 // Capture stack trace for a detailed exception message.
644 Handle<String> key = factory()->hidden_stack_trace_symbol(); 645 Handle<String> key = factory()->hidden_stack_trace_symbol();
645 Handle<JSArray> stack_trace = CaptureCurrentStackTrace( 646 Handle<JSArray> stack_trace = CaptureCurrentStackTrace(
646 stack_trace_for_uncaught_exceptions_frame_limit_, 647 stack_trace_for_uncaught_exceptions_frame_limit_,
(...skipping 1529 matching lines...) Expand 10 before | Expand all | Expand 10 after
2176 2177
2177 #ifdef DEBUG 2178 #ifdef DEBUG
2178 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \ 2179 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \
2179 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_); 2180 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_);
2180 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET) 2181 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET)
2181 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET) 2182 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET)
2182 #undef ISOLATE_FIELD_OFFSET 2183 #undef ISOLATE_FIELD_OFFSET
2183 #endif 2184 #endif
2184 2185
2185 } } // namespace v8::internal 2186 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap-inl.h ('k') | src/list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698