Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 11377141: Selective build clobbering feature (landmines.py and android build scripts). (Closed)

Created:
8 years, 1 month ago by iannucci
Modified:
8 years, 1 month ago
Reviewers:
Isaac (away), M-A Ruel
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Selective build clobbering feature (landmines.py and android build scripts). Adds the ability for devs/troopers/etc. to set 'landmines' in the tree so that the build will selectively clobber when a builder moves over a revision with such a change. This cl has an basis landmines.py, and hooks the clobber mechanism to the android build scripts. The relevant cl which implements this for compile.py is here: https://chromiumcodereview.appspot.com/11234013/ I'm planning to also implement an informational invocation for gclient to let devs know about any potential landmines so they can decide if they need to clobber. This previously attempted to land as: https://chromiumcodereview.appspot.com/11175016 R=ilevy@chromium.org,maruel@chromium.org BUG=121897 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167595

Patch Set 1 #

Total comments: 2

Patch Set 2 : formatting fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -50 lines) Patch
M DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
M build/android/buildbot/buildbot_functions.sh View 2 chunks +31 lines, -16 lines 0 comments Download
M build/gyp_chromium View 3 chunks +2 lines, -34 lines 0 comments Download
A build/gyp_helper.py View 1 1 chunk +50 lines, -0 lines 0 comments Download
A build/landmines.py View 1 chunk +210 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
iannucci
Fresh new cl from https://codereview.chromium.org/11175016/ :). PTAL
8 years, 1 month ago (2012-11-13 20:34:09 UTC) #1
M-A Ruel
lgtm but wait for Isaac too. https://codereview.chromium.org/11377141/diff/1/build/gyp_helper.py File build/gyp_helper.py (right): https://codereview.chromium.org/11377141/diff/1/build/gyp_helper.py#newcode25 build/gyp_helper.py:25: supported_vars = ( ...
8 years, 1 month ago (2012-11-13 21:35:02 UTC) #2
iannucci
https://chromiumcodereview.appspot.com/11377141/diff/1/build/gyp_helper.py File build/gyp_helper.py (right): https://chromiumcodereview.appspot.com/11377141/diff/1/build/gyp_helper.py#newcode25 build/gyp_helper.py:25: supported_vars = ( 'CC', On 2012/11/13 21:35:02, Marc-Antoine Ruel ...
8 years, 1 month ago (2012-11-13 22:04:06 UTC) #3
Isaac (away)
lgtm
8 years, 1 month ago (2012-11-14 00:25:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/11377141/4001
8 years, 1 month ago (2012-11-14 01:12:35 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-14 04:59:50 UTC) #6
Change committed as 167595

Powered by Google App Engine
This is Rietveld 408576698