Chromium Code Reviews
Help | Chromium Project | Sign in
(167)

Issue 11377134: Output max incremental step delay in trace_gc_nvp. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by ulan
Modified:
2 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Output max incremental step delay in trace_gc_nvp. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12959

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/heap.cc View 1 chunk +1 line, -0 lines 2 comments Download
Trybot results:
Project "None" does not have a commit queue.

Messages

Total messages: 2 (0 generated)
ulan
PTAL https://chromiumcodereview.appspot.com/11377134/diff/1/src/heap.cc File src/heap.cc (right): https://chromiumcodereview.appspot.com/11377134/diff/1/src/heap.cc#newcode7230 src/heap.cc:7230: PrintF("longeststep=%.f ", longest_step_); Note that I am rounding ...
2 years, 9 months ago (2012-11-13 15:30:02 UTC) #1
Michael Starzinger
2 years, 9 months ago (2012-11-14 11:35:39 UTC) #2
LGTM.

https://codereview.chromium.org/11377134/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/11377134/diff/1/src/heap.cc#newcode7230
src/heap.cc:7230: PrintF("longeststep=%.f ", longest_step_);
On 2012/11/13 15:30:02, ulan wrote:
> Note that I am rounding to int here, we probably don't need sub-ms precision.

I think printing an integer here is fine. But note that the values won't have
much of a variance. Unless the GC totally screws up, they are between 0 and 3 on
my machine.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c33a7a4