Customize user details in ash system bubble for public account mode

ash/system/tray/tray_constants.cc

Index: ash/system/tray/tray_constants.cc
diff --git a/ash/system/tray/tray_constants.cc b/ash/system/tray/tray_constants.cc
index b9e6863d57f8eb994e78b461d2da5226cecbac91..b2f0248c8bed51291109ffc381d89d68155eba19 100644
--- a/ash/system/tray/tray_constants.cc
+++ b/ash/system/tray/tray_constants.cc
@@ -35,6 +35,8 @@ const int kTrayBarButtonWidth = 39;
 const SkColor kBackgroundColor = SkColorSetRGB(0xfe, 0xfe, 0xfe);
 const SkColor kHoverBackgroundColor = SkColorSetRGB(0xf5, 0xf5, 0xf5);
 const SkColor kPublicAccountBackgroundColor = SkColorSetRGB(0xf8, 0xe5, 0xb6);
+const SkColor kPublicAccountUserCardTextColor = SkColorSetRGB(0x66, 0x66, 0x66);
+const SkColor kPublicAccountUserCardNameColor = SK_ColorBLACK;
 
 const SkColor kHeaderBackgroundColorLight = SkColorSetRGB(0xf1, 0xf1, 0xf1);
 const SkColor kHeaderBackgroundColorDark = SkColorSetRGB(0xe7, 0xe7, 0xe7);
@@ -46,9 +48,10 @@ const SkColor kButtonStrokeColor = SkColorSetRGB(0xdd, 0xdd, 0xdd);
 const SkColor kHeaderTextColorNormal = SkColorSetARGB(0x7f, 0, 0, 0);
 const SkColor kHeaderTextColorHover = SkColorSetARGB(0xd3, 0, 0, 0);
 
-const int kTrayPopupWidth = 300;
+const int kTrayPopupMinWidth = 300;
+const int kTrayPopupMaxWidth = 500;
 const int kNotificationIconWidth = 40;
-const int kTrayNotificationContentsWidth =
-    kTrayPopupWidth - kNotificationIconWidth*2 - kTrayPopupPaddingHorizontal*2;
+const int kTrayNotificationContentsWidth = kTrayPopupMinWidth -

[msw, 2012/11/29 01:14:10]

nit: does newly variable bubble width break this const? consider TODO/followup.

[bartfab (slow), 2012/11/29 16:28:59]

No, the new variable bubble width does not break this const. The variable width
is used in the main system tray bubble only and this const is for notification
bubbles.

+    (kNotificationIconWidth + kTrayPopupPaddingHorizontal) * 2;

[msw, 2012/11/29 01:14:10]

nit: you didn't change this, but why does this calculation multiply
|kNotificationIconWidth| by two, whereas the similar |msg_width| calculation in
ash/system/chromeos/network/tray_sms.cc does not? I suspect this is wrong.

[bartfab (slow), 2012/11/29 16:28:59]

From my reading of TrayNotificationView::InitView(), something is definitely off
here. A notification view has a grid layout with the following column widths:

* kTrayPopupPaddingHorizontal / 2
* kNotificationIconWidth
* kTrayPopupPaddingHorizontal / 2
* kTrayNotificationContentsWidth
* kTrayPopupPaddingHorizontal / 2
* kNotificationButtonWidth

There are a number of things wrong:

1) There is no padding column after the close button
2) As you pointed out and I actually noticed myself before, the icon width is
counted twice in |kTrayNotificationContentsWidth|
3) The width of the close button is not counted at all in
|kTrayNotificationContentsWidth|.

Since I did not look into this code in more detail, I do not want to just change
the constant and hope for the best. Should I add a TODO(msw) to look into this?

[msw, 2012/11/29 18:37:46]

You can add a TODO and file an issue for the relevant author, which is not me.

[bartfab (slow), 2012/11/29 19:15:01]

Done.

 
 }  // namespace ash