Support all fast elements kinds in the major array operations.

src/parser.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3768 matching lines @@
         // until the first value is seen that can't be stored as a double.
         if (boilerplate_value->IsNumber()) {
           double_literals->set(i, boilerplate_value->Number());
         } else {
           elements_kind = FAST_ELEMENTS;
         }
       }
     }
   }
 
   // Very small array literals that don't have a concrete hint about their type

[danno, 2012/11/13 22:05:12]

Remove all the code from this line (beginning of comment)

[Toon Verwaest, 2012/11/14 11:53:13]

Done.

   // from a constant value should default to the slow case to avoid lots of
   // elements transitions on really small objects.
-  if (has_only_undefined_values && values->length() <= 2) {
-    elements_kind = FAST_ELEMENTS;
+  if (has_only_undefined_values &&
+      values->length() <= 2 &&
+      values->length() > 0) {
+    // elements_kind = FAST_ELEMENTS;
   }

[danno, 2012/11/13 22:05:12]

... to here.

[Toon Verwaest, 2012/11/14 11:53:13]

Done.

 
   // Simple and shallow arrays can be lazily copied, we transform the
   // elements array to a copy-on-write array.
   if (is_simple && depth == 1 && values->length() > 0 &&
       elements_kind != FAST_DOUBLE_ELEMENTS) {
     object_literals->set_map(heap->fixed_cow_array_map());
   }
 
   Handle<FixedArrayBase> element_values = elements_kind == FAST_DOUBLE_ELEMENTS
       ? Handle<FixedArrayBase>(double_literals)
@@ skipping 2175 matching lines @@
       ASSERT(info->isolate()->has_pending_exception());
     } else {
       result = parser.ParseProgram();
     }
   }
   info->SetFunction(result);
   return (result != NULL);
 }
 
 } }  // namespace v8::internal