Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3796)

Unified Diff: chrome/browser/media_gallery/media_file_system_registry.cc

Issue 11377131: Removing PrefObserver usage, batch 4. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to review comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media_gallery/media_file_system_registry.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media_gallery/media_file_system_registry.cc
diff --git a/chrome/browser/media_gallery/media_file_system_registry.cc b/chrome/browser/media_gallery/media_file_system_registry.cc
index c97943dafa9d555e3807737842e9be7424b3c8fa..10811764f4b3a292ce230ac8458e9ab7e1bd4098 100644
--- a/chrome/browser/media_gallery/media_file_system_registry.cc
+++ b/chrome/browser/media_gallery/media_file_system_registry.cc
@@ -490,7 +490,12 @@ void MediaFileSystemRegistry::GetMediaFileSystemsForExtension(
if (!ContainsKey(pref_change_registrar_map_, profile)) {
PrefChangeRegistrar* pref_registrar = new PrefChangeRegistrar;
pref_registrar->Init(profile->GetPrefs());
- pref_registrar->Add(prefs::kMediaGalleriesRememberedGalleries, this);
+ pref_registrar->Add(
+ prefs::kMediaGalleriesRememberedGalleries,
+ base::Bind(&MediaFileSystemRegistry::
+ OnMediaGalleriesRememberedGalleriesChanged,
+ base::Unretained(this),
+ pref_registrar->prefs()));
pref_change_registrar_map_[profile] = pref_registrar;
}
@@ -672,11 +677,8 @@ MediaFileSystemRegistry::~MediaFileSystemRegistry() {
system_monitor->RemoveDevicesChangedObserver(this);
}
-void MediaFileSystemRegistry::OnPreferenceChanged(
- PrefServiceBase* prefs,
- const std::string& pref_name) {
- DCHECK_EQ(std::string(prefs::kMediaGalleriesRememberedGalleries), pref_name);
-
+void MediaFileSystemRegistry::OnMediaGalleriesRememberedGalleriesChanged(
+ PrefServiceBase* prefs) {
// Find the Profile that contains the source PrefService.
PrefChangeRegistrarMap::iterator pref_change_it =
pref_change_registrar_map_.begin();
« no previous file with comments | « chrome/browser/media_gallery/media_file_system_registry.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698