Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: chrome/browser/extensions/api/preference/preference_api.cc

Issue 11377131: Removing PrefObserver usage, batch 4. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to review comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/preference/preference_api.cc
diff --git a/chrome/browser/extensions/api/preference/preference_api.cc b/chrome/browser/extensions/api/preference/preference_api.cc
index 46e6751d1e82fbc313ef9bb1bdf6309ada254139..50d279e2988ce38bf78bdf5fb260a812ad043b37 100644
--- a/chrome/browser/extensions/api/preference/preference_api.cc
+++ b/chrome/browser/extensions/api/preference/preference_api.cc
@@ -246,18 +246,19 @@ PreferenceEventRouter::PreferenceEventRouter(Profile* profile)
registrar_.Init(profile_->GetPrefs());
incognito_registrar_.Init(profile_->GetOffTheRecordPrefs());
for (size_t i = 0; i < arraysize(kPrefMapping); ++i) {
- registrar_.Add(kPrefMapping[i].browser_pref, this);
- incognito_registrar_.Add(kPrefMapping[i].browser_pref, this);
+ registrar_.Add(kPrefMapping[i].browser_pref,
+ base::Bind(&PreferenceEventRouter::OnPrefChanged,
+ base::Unretained(this),
+ registrar_.prefs()));
+ incognito_registrar_.Add(kPrefMapping[i].browser_pref,
+ base::Bind(&PreferenceEventRouter::OnPrefChanged,
+ base::Unretained(this),
+ incognito_registrar_.prefs()));
}
}
PreferenceEventRouter::~PreferenceEventRouter() { }
-void PreferenceEventRouter::OnPreferenceChanged(PrefServiceBase* service,
- const std::string& pref_name) {
- OnPrefChanged(service, pref_name);
-}
-
void PreferenceEventRouter::OnPrefChanged(PrefServiceBase* pref_service,
const std::string& browser_pref) {
bool incognito = (pref_service != profile_->GetPrefs());
« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.h ('k') | chrome/browser/extensions/component_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698