Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 11377117: Remove AppResource and unneeded resources. (Closed)

Created:
8 years, 1 month ago by newt (away)
Modified:
8 years ago
CC:
chromium-reviews, jam, android-webview-reviews_chromium.org, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org, darin-cc_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Remove AppResource and unneeded resources. Now that content and chrome have their own resources and are accessing them via the org.chromium.[content|chrome].R classes, we can remove the duplicates of these resources that live in content shell and test shell as well as any remaining references to AppResource.java. This is the third of three CLs to replace AppResource with R: 1. http://codereview.chromium.org/11363150 - Support Java resources within content 2. http://codereview.chromium.org/11360207 - Add Java resources to content and chrome 3. http://codereview.chromium.org/11377117 - Remove AppResource and unneeded resources BUG=136704 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169633

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-6 lines, -309 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwTestResourceProvider.java View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java View 1 3 chunks +0 lines, -22 lines 0 comments Download
D chrome/android/testshell/res/drawable-nodpi/popup_zoomer_overlay.9.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/android/testshell/res/drawable/ic_menu_search_holo_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/android/testshell/res/drawable/ic_menu_share_holo_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/android/testshell/res/layout/autofill_text.xml View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/android/testshell/res/values/dimens.xml View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/android/testshell/res/values/strings.xml View 1 chunk +0 lines, -14 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/AppResource.java View 1 chunk +0 lines, -184 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/ContentShellActivity.java View 1 3 chunks +0 lines, -19 lines 0 comments Download
D content/shell/android/res/drawable-nodpi/popup_zoomer_overlay.9.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D content/shell/android/res/drawable/ic_menu_search_holo_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D content/shell/android/res/drawable/ic_menu_share_holo_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D content/shell/android/res/values/dimens.xml View 1 chunk +0 lines, -14 lines 0 comments Download
M content/shell/android/res/values/strings.xml View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
newt (away)
Primary reviewers: +benm +cjhopman Secondary reviewer: +tedchoc PTAL, thanks!
8 years, 1 month ago (2012-11-15 01:02:10 UTC) #1
benm (inactive)
lgtm
8 years, 1 month ago (2012-11-15 15:27:37 UTC) #2
Ted C
lgtm
8 years, 1 month ago (2012-11-15 18:29:00 UTC) #3
cjhopman
lgtm
8 years, 1 month ago (2012-11-15 19:08:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/11377117/6001
8 years ago (2012-11-27 06:45:44 UTC) #5
commit-bot: I haz the power
8 years ago (2012-11-27 10:53:35 UTC) #6
Message was sent while issue was closed.
Change committed as 169633

Powered by Google App Engine
This is Rietveld 408576698