Issue 11377113: ChromeOS needs UTF-8 appended to locale. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(225)

My Issues | Starred Open | Closed | All

Issue 11377113: ChromeOS needs UTF-8 appended to locale. (Closed)

Created:
8 years, 1 month ago by ilja

Modified:
8 years, 1 month ago

Reviewers:
brettw, Scott Hess - ex-Googler, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

ChromeOS needs UTF-8 appended to locale. TEST=Song Pop, Farmville 2, HBOgo. BUG=134911, 153966, 155396 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167552

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/ppapi_plugin/ppapi_plugin_main.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

lgtm. Per my TODO, this should be safe for OSX, also. 'locale' from the OSX ...

8 years, 1 month ago (2012-11-12 20:35:19 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ihf@chromium.org/11377113/4001

8 years, 1 month ago (2012-11-13 22:32:54 UTC) #6

Change committed as 167552

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698