Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 11377088: cc: Prevent small scale factors (below 1) from being used or saved as the layer's rasterScale. (Closed)

Created:
8 years, 1 month ago by danakj
Modified:
8 years, 1 month ago
Reviewers:
jamesr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman, backer
Visibility:
Public.

Description

cc: Prevent small scale factors (below 1) from being used or saved as the layer's rasterScale. When the scale is < 1, then we don't save anything. The first time we see a scale >= 1, we will save it. Tests: cc_unittests:LayerTreeHostCommonTest.verifySmallContentsScale BUG=159655 R=enne,jamesr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167040

Patch Set 1 #

Patch Set 2 : smallpsf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1 line) Patch
M cc/layer_tree_host_common.cc View 1 chunk +5 lines, -1 line 0 comments Download
M cc/layer_tree_host_common_unittest.cc View 1 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
danakj
8 years, 1 month ago (2012-11-09 23:11:51 UTC) #1
enne (OOO)
lgtm
8 years, 1 month ago (2012-11-09 23:15:57 UTC) #2
aelias_OOO_until_Jul13
What's the motivation for this? It would make us paint unnecessarily expensively when zoomed out ...
8 years, 1 month ago (2012-11-09 23:19:04 UTC) #3
danakj
On 2012/11/09 23:19:04, aelias wrote: > What's the motivation for this? It would make us ...
8 years, 1 month ago (2012-11-09 23:19:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11377088/1
8 years, 1 month ago (2012-11-09 23:19:50 UTC) #5
danakj
On 2012/11/09 23:19:29, danakj wrote: > On 2012/11/09 23:19:04, aelias wrote: > > What's the ...
8 years, 1 month ago (2012-11-09 23:20:10 UTC) #6
danakj
On 2012/11/09 23:20:10, danakj wrote: > On 2012/11/09 23:19:29, danakj wrote: > > On 2012/11/09 ...
8 years, 1 month ago (2012-11-09 23:22:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11377088/12001
8 years, 1 month ago (2012-11-09 23:22:11 UTC) #8
aelias_OOO_until_Jul13
OK, thanks for the explanation, I commented before reading closely enough. LGTM.
8 years, 1 month ago (2012-11-09 23:24:33 UTC) #9
commit-bot: I haz the power
8 years, 1 month ago (2012-11-10 03:06:22 UTC) #10
Change committed as 167040

Powered by Google App Engine
This is Rietveld 408576698