Issue 11377054: Packaged Files app: open files from Downloads tab

Issue 11377054: Packaged Files app: open files from Downloads tab (Closed)

Created:
8 years, 1 month ago by Vladislav Kaznacheev

Modified:
8 years, 1 month ago

Reviewers:
dgozman

CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Packaged Files app: open files from Downloads tab BUG=160007 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166681

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -77 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager_util.cc	View		9 chunks	+98 lines, -60 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/background.js	View	1	5 chunks	+36 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1	3 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_tasks.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dgozman

LGTM with comments https://chromiumcodereview.appspot.com/11377054/diff/1/chrome/browser/resources/file_manager/js/background.js File chrome/browser/resources/file_manager/js/background.js (right): https://chromiumcodereview.appspot.com/11377054/diff/1/chrome/browser/resources/file_manager/js/background.js#newcode23 chrome/browser/resources/file_manager/js/background.js:23: launchAudioPlayer({items: [url], position: 0}); Why don't ...

8 years, 1 month ago (2012-11-08 13:49:28 UTC) #2

Vladislav Kaznacheev

Thanks for the review. Committing. https://chromiumcodereview.appspot.com/11377054/diff/1/chrome/browser/resources/file_manager/js/background.js File chrome/browser/resources/file_manager/js/background.js (right): https://chromiumcodereview.appspot.com/11377054/diff/1/chrome/browser/resources/file_manager/js/background.js#newcode23 chrome/browser/resources/file_manager/js/background.js:23: launchAudioPlayer({items: [url], position: 0}); ...

8 years, 1 month ago (2012-11-08 14:00:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/11377054/3002

8 years, 1 month ago (2012-11-08 14:00:43 UTC) #4

Change committed as 166681

Expand Messages | Collapse Messages