Issue 11377017: cc: Fix nine patch layer resource management bugs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11377017: cc: Fix nine patch layer resource management bugs. (Closed)

Created:
8 years, 1 month ago by aelias_OOO_until_Jul13

Modified:
8 years, 1 month ago

Reviewers:
jamesr, Jerome

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

cc: Fix nine patch layer resource management bugs. This switches back to using if (m_resource) in pushPropertiesTo() since it may be called before setNeedsDisplay(). Also, switch to checking if resourceId == 0 instead of backingResourceIsDeleted() since that asserts it's only called on the impl thread. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166399

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -13 lines)			Patch
	M	cc/nine_patch_layer.cc	View		2 chunks	+6 lines, -5 lines	0 comments	Download
	M	cc/nine_patch_layer_unittest.cc	View		2 chunks	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

aelias_OOO_until_Jul13

Hi, these are some bugs that turn up when actually using nine patch layer in ...

8 years, 1 month ago (2012-11-07 02:22:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/11377017/1

8 years, 1 month ago (2012-11-07 03:05:44 UTC) #3

Change committed as 166399

Expand Messages | Collapse Messages