Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 11377013: Add touchEventHandlerRegion to Layer and LayerImpl (Closed)

Created:
8 years, 1 month ago by Yusuf
Modified:
8 years, 1 month ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org, leviw_travelin_and_unemployed
Visibility:
Public.

Description

Add touchEventHandlerRegion to Layer and LayerImpl These will be used to keep track of JavaScript touch event handler on the compositor thread and will be updated accordingly when there is a change involving adding/removing or changing the layout of the nodes that contain the touch event handlers. BUG=135818 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166561

Patch Set 1 #

Patch Set 2 : Removed OVERRIDE from web_layer_impl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M cc/layer.h View 2 chunks +6 lines, -0 lines 0 comments Download
M cc/layer.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M cc/layer_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/compositor_bindings/web_layer_impl.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/compositor_bindings/web_layer_impl.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuf
How should I go about submitting this and the WebKit counterpart? I think the OVERRIDE ...
8 years, 1 month ago (2012-11-07 01:53:40 UTC) #1
jamesr
On 2012/11/07 01:53:40, Yusuf wrote: > How should I go about submitting this and the ...
8 years, 1 month ago (2012-11-07 04:48:31 UTC) #2
jamesr
lgtm, but take the OVERRIDEs out before landing or it will break builds as you ...
8 years, 1 month ago (2012-11-07 04:50:00 UTC) #3
Yusuf
Done. I will wait for the WebKit side to go in and send a try ...
8 years, 1 month ago (2012-11-07 18:48:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/11377013/3001
8 years, 1 month ago (2012-11-07 22:17:38 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-08 00:33:38 UTC) #6
Change committed as 166561

Powered by Google App Engine
This is Rietveld 408576698