Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11377005: Replace Label::Alignment with gfx::HorizontalAlignment (Closed)

Created:
8 years, 1 month ago by msw
Modified:
8 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, asanka, sadrul, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, dcheng, groby+watch_chromium.org, markusheintz_, Ilya Sherman, yusukes+watch_chromium.org, ben+watch_chromium.org, stevenjb+watch_chromium.org, dbeam+watch-autofill_chromium.org, rouslan+watch_chromium.org, gbillock+watch_chromium.org, chromium-apps-reviews_chromium.org, tim (not reviewing), jennb, Raghu Simha, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, Randy Smith (Not in Mondays), jianli, oshima+watch_chromium.org, smckay+watch_chromium.org, Albert Bodenhamer, haitaol1, akalin, tfarina, Dmitry Titov, Aaron Boodman, dyu1, estade+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Replace Label::Alignment with gfx::HorizontalAlignment. Also remove unnecessary center alignment specifications in: ash/wm/maximize_bubble_controller.cc chrome/browser/ui/views/find_bar_view.cc chrome/browser/ui/views/panels/panel_frame_view.cc chrome/browser/ui/views/speech_recognition_bubble_views.cc ui/message_center/message_center_bubble.cc BUG=90426, 155526 TEST=No behavioral changes. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166462

Patch Set 1 #

Patch Set 2 : Remove unnecessary center alignment specifications. #

Patch Set 3 : Sync and rebase. #

Patch Set 4 : Fix remaining Label::Alignment references. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -207 lines) Patch
M ash/display/display_error_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_tooltip_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/tray_network.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/network/tray_sms.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/date/date_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/drive/tray_drive.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/ime/tray_ime.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/locale/tray_locale.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/power/power_status_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray_caps_lock.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/user/tray_user.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/maximize_bubble_controller.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/enrollment_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window.cc View 1 2 3 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/message_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/password_changed_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/take_photo_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ui/idle_logout_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_bubble_view.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_prompt_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/confirm_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_window_frame_simple.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/critical_notification_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/edit_search_engine_dialog.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/bundle_installed_bubble.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/disabled_extensions_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/global_error_bubble_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/importer/import_lock_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/importer/import_progress_dialog_view.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/login_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/network_profile_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/page_info_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/panels/panel_frame_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/speech_recognition_bubble_views.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/uninstall_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/web_intent_picker_views.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/base_format_view.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/message_center/message_center_bubble.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/message_simple_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/label_button.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M ui/views/controls/button/label_button_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/views/controls/label.h View 4 chunks +6 lines, -7 lines 0 comments Download
M ui/views/controls/label.cc View 5 chunks +16 lines, -14 lines 0 comments Download
M ui/views/controls/label_unittest.cc View 21 chunks +34 lines, -36 lines 0 comments Download
M ui/views/controls/message_box_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/examples/button_example.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/examples/label_example.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/focus/focus_traversal_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
msw
Hey Scott, please take a look; thanks!
8 years, 1 month ago (2012-11-07 09:01:07 UTC) #1
sky
LGTM - I wonder why we made center the default. Sure seems like LEFT is ...
8 years, 1 month ago (2012-11-07 14:51:27 UTC) #2
msw
On 2012/11/07 14:51:27, sky wrote: > LGTM - I wonder why we made center the ...
8 years, 1 month ago (2012-11-07 16:15:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/11377005/8015
8 years, 1 month ago (2012-11-07 16:15:53 UTC) #4
commit-bot: I haz the power
Change committed as 166462
8 years, 1 month ago (2012-11-07 17:37:39 UTC) #5
Philippe
On 2012/11/07 17:37:39, I haz the power (commit-bot) wrote: > Change committed as 166462 It ...
8 years, 1 month ago (2012-11-07 17:49:06 UTC) #6
Philippe
8 years, 1 month ago (2012-11-07 17:55:13 UTC) #7 
On 2012/11/07 17:49:06, Philippe wrote:
> On 2012/11/07 17:37:39, I haz the power (commit-bot) wrote:
> > Change committed as 166462
> 
> It seems that this change broke the Android build (and possibly others):
>
http://build.chromium.org/p/chromium.linux/builders/Android%2520Clang%2520Bui...

Please ignore my previous comment :)

Powered by Google App Engine
This is Rietveld 408576698