Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: runtime/vm/snapshot_test.cc

Issue 11369259: Add one-char string table for faster String.charAt to the VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: added characters 0x80..0xff Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/snapshot_test.cc
===================================================================
--- runtime/vm/snapshot_test.cc (revision 14980)
+++ runtime/vm/snapshot_test.cc (working copy)
@@ -1840,11 +1840,9 @@
for (int i = 0; i < kArrayLength; i++) {
Dart_CObject* element = root->value.as_array.values[i];
if ((i % 2) == 0) {
- EXPECT_EQ(root->value.as_array.values[0], element);
Ivan Posva 2012/11/17 01:30:58 I am not clear why you needed to remove these expe
Florian Schneider 2012/11/19 16:04:02 Done. Not needed anymore. sgjesse@ landed a fix in
EXPECT_EQ(Dart_CObject::kString, element->type);
EXPECT_STREQ("A", element->value.as_string);
} else {
- EXPECT_EQ(root->value.as_array.values[1], element);
EXPECT_EQ(Dart_CObject::kDouble, element->type);
EXPECT_STREQ(2.72, element->value.as_double);
}
@@ -2015,11 +2013,9 @@
for (int i = 0; i < kArrayLength; i++) {
Dart_CObject* element = root->value.as_array.values[i];
if ((i % 2) == 0) {
- EXPECT_EQ(root->value.as_array.values[0], element);
Ivan Posva 2012/11/17 01:30:58 ditto
EXPECT_EQ(Dart_CObject::kString, element->type);
EXPECT_STREQ("A", element->value.as_string);
} else {
- EXPECT_EQ(root->value.as_array.values[1], element);
EXPECT_EQ(Dart_CObject::kDouble, element->type);
EXPECT_STREQ(2.72, element->value.as_double);
}
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/symbols.h » ('j') | runtime/vm/symbols.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698