runtime/lib/string.cc - Issue 11369259: Add one-char string table for faster String.charAt to the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/string.cc

Issue 11369259: Add one-char string table for faster String.charAt to the VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: added characters 0x80..0xff Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/string.cc

===================================================================

--- runtime/lib/string.cc (revision 14980)

+++ runtime/lib/string.cc (working copy)

@@ -102,7 +102,7 @@

GET_NATIVE_ARGUMENT(Integer, index, arguments->NativeArgAt(1));

uint32_t value = StringValueAt(receiver, index);

ASSERT(value <= 0x10FFFF);

- return Symbols::New(&value, 1);

+ return Symbols::FromCharCode(value);

}

DEFINE_NATIVE_ENTRY(String_charCodeAt, 2) {

« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | runtime/vm/snapshot_test.cc » ('J')