Fix crash when programatically closing media gallery dialog

Fix crash when programatically closing media gallery dialog

If the media gallery dialog was closed by something other than clicking "Cancel" or "Ok" then Chrome would crash.

The problem was that a bug in the way that I was closing the dialog. I was doing endSheet:alert when I should be doing endSheet:[alert window].

BUG=156537
TBR=ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167819

[sail, 2012-11-14 21:07:56]

+avi for cocoa/*
+estade for media_gallery/*

[Avi (use Gerrit), 2012-11-14 21:17:41]

Tests are awesome. lgtm!

https://codereview.chromium.org/11369253/diff/1/chrome/browser/ui/cocoa/exten...
File
chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_browsertest.mm
(right):

https://codereview.chromium.org/11369253/diff/1/chrome/browser/ui/cocoa/exten...
chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_browsertest.mm:25:
IN_PROC_BROWSER_TEST_F(MediaGalleriesDialogBrowserTest, Close) {
Whoooooo!

[Evan Stade, 2012-11-14 21:58:47]

lgtm

[commit-bot: I haz the power, 2012-11-14 22:04:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/11369253/1

[commit-bot: I haz the power, 2012-11-14 22:04:23]

Presubmit check for 11369253-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 4.2s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-11-14 22:06:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/11369253/1

[commit-bot: I haz the power, 2012-11-15 00:29:27]

Retried try job too often for step(s) content_unittests

[commit-bot: I haz the power, 2012-11-15 00:37:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/11369253/1

[commit-bot: I haz the power, 2012-11-15 01:52:23]

Change committed as 167819