Only show landmines output if the environment says so.

build/landmines.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 This file holds a list of reasons why a particular build needs to be clobbered
 (or a list of 'landmines').
 
 This script runs every build as a hook. If it detects that the build should
@@ skipping 18 matching lines @@
 
 def memoize(default=None):
   """This decorator caches the return value of a parameterless pure function"""
   def memoizer(func):
     val = []
     @functools.wraps(func)
     def inner():
       if not val:
         ret = func()
         val.append(ret if ret is not None else default)
-        print '%s -> %r' % (func.__name__, val[0])
+        if 'LANDMINES_VERBOSE' in os.environ:

[M-A Ruel, 2012/11/14 13:03:36]

I prefer when you use a --verbose flag and
default=bool(try_int(os.environ.get('LANDMINES_VERBOSE', '0')))
with try_int be a safe int conversion function. Otherwise, how someone is
supposed to figure out how to do this without reading the whole code?

This means using optparse though but I think it's worth in that case.

+          print '%s -> %r' % (func.__name__, val[0])
       return val[0]
     return inner
   return memoizer
 
 
 @memoize()
 def IsWindows():
   return sys.platform.startswith('win') or sys.platform == 'cygwin'
 
 
@@ skipping 151 matching lines @@
           f.writelines(diff)
       elif os.path.exists(triggered):
         # Remove false triggered landmines.
         os.remove(triggered)
 
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))