Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 11369042: Caches the display names in MultiDisplayManager. (Closed)

Created:
8 years, 1 month ago by Jun Mukai
Modified:
8 years, 1 month ago
Reviewers:
Daniel Erat, oshima
CC:
chromium-reviews, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Caches the display names in MultiDisplayManager. BUG=159034 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165775

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 9

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -54 lines) Patch
M ash/ash_strings.grd View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M ash/display/multi_display_manager.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M ash/display/multi_display_manager.cc View 1 2 3 5 chunks +41 lines, -23 lines 0 comments Download
M ash/system/chromeos/tray_display.cc View 1 2 3 4 chunks +30 lines, -31 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Jun Mukai
8 years, 1 month ago (2012-11-02 03:22:27 UTC) #1
oshima
http://codereview.chromium.org/11369042/diff/1/ash/display/multi_display_manager.cc File ash/display/multi_display_manager.cc (right): http://codereview.chromium.org/11369042/diff/1/ash/display/multi_display_manager.cc#newcode556 ash/display/multi_display_manager.cc:556: std::string result; this isn't used? http://codereview.chromium.org/11369042/diff/1/ash/display/multi_display_manager.cc#newcode567 ash/display/multi_display_manager.cc:567: if (!HasInternalDisplay() ...
8 years, 1 month ago (2012-11-02 06:33:56 UTC) #2
Jun Mukai
https://codereview.chromium.org/11369042/diff/1/ash/display/multi_display_manager.cc File ash/display/multi_display_manager.cc (right): https://codereview.chromium.org/11369042/diff/1/ash/display/multi_display_manager.cc#newcode556 ash/display/multi_display_manager.cc:556: std::string result; On 2012/11/02 06:33:56, oshima wrote: > this ...
8 years, 1 month ago (2012-11-02 16:09:07 UTC) #3
oshima
lgtm with a nit https://codereview.chromium.org/11369042/diff/5001/ash/display/multi_display_manager.cc File ash/display/multi_display_manager.cc (right): https://codereview.chromium.org/11369042/diff/5001/ash/display/multi_display_manager.cc#newcode561 ash/display/multi_display_manager.cc:561: if (HasInternalDisplay() && IsInternalDisplayId(display.id())) { ...
8 years, 1 month ago (2012-11-02 16:35:11 UTC) #4
Jun Mukai
https://codereview.chromium.org/11369042/diff/5001/ash/display/multi_display_manager.cc File ash/display/multi_display_manager.cc (right): https://codereview.chromium.org/11369042/diff/5001/ash/display/multi_display_manager.cc#newcode561 ash/display/multi_display_manager.cc:561: if (HasInternalDisplay() && IsInternalDisplayId(display.id())) { On 2012/11/02 16:35:11, oshima ...
8 years, 1 month ago (2012-11-02 16:37:53 UTC) #5
Jun Mukai
derat, can you review this?
8 years, 1 month ago (2012-11-02 16:38:43 UTC) #6
Daniel Erat
https://codereview.chromium.org/11369042/diff/10001/ash/ash_strings.grd File ash/ash_strings.grd (right): https://codereview.chromium.org/11369042/diff/10001/ash/ash_strings.grd#newcode352 ash/ash_strings.grd:352: <message name="IDS_ASH_STATUS_TRAY_UNKNOWN_DISPLAY_NAME" desc="The name of the display used in ...
8 years, 1 month ago (2012-11-02 16:46:16 UTC) #7
Jun Mukai
https://codereview.chromium.org/11369042/diff/10001/ash/ash_strings.grd File ash/ash_strings.grd (right): https://codereview.chromium.org/11369042/diff/10001/ash/ash_strings.grd#newcode352 ash/ash_strings.grd:352: <message name="IDS_ASH_STATUS_TRAY_UNKNOWN_DISPLAY_NAME" desc="The name of the display used in ...
8 years, 1 month ago (2012-11-02 18:04:35 UTC) #8
Daniel Erat
lgtm https://codereview.chromium.org/11369042/diff/10001/ash/display/multi_display_manager.cc File ash/display/multi_display_manager.cc (right): https://codereview.chromium.org/11369042/diff/10001/ash/display/multi_display_manager.cc#newcode387 ash/display/multi_display_manager.cc:387: std::string MultiDisplayManager::GetDisplayNameFor( On 2012/11/02 18:04:35, Jun Mukai wrote: ...
8 years, 1 month ago (2012-11-02 18:59:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/11369042/5
8 years, 1 month ago (2012-11-02 20:33:03 UTC) #10
commit-bot: I haz the power
8 years, 1 month ago (2012-11-02 22:26:54 UTC) #11
Change committed as 165775

Powered by Google App Engine
This is Rietveld 408576698