Calling SendSAS() from a service yo make sure that Secure Attention Sequence can be injected even w…

remoting/host/win/session_event_executor.h

Index: remoting/host/win/session_event_executor.h
diff --git a/remoting/host/win/session_event_executor.h b/remoting/host/win/session_event_executor.h
index 118238d72661138bd927154d080ba0f8d37c88e6..3dac43808ad30b4a0f899841443beff675496630 100644
--- a/remoting/host/win/session_event_executor.h
+++ b/remoting/host/win/session_event_executor.h
@@ -8,6 +8,7 @@
 #include <set>
 
 #include "base/basictypes.h"
+#include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "remoting/host/event_executor.h"
@@ -24,8 +25,10 @@ class SasInjector;
 class SessionEventExecutorWin : public EventExecutor {
  public:
   SessionEventExecutorWin(
-      scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
-      scoped_ptr<EventExecutor> nested_executor);
+      scoped_refptr<base::SingleThreadTaskRunner> input_task_runner,
+      scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,

[Wez, 2012/11/01 20:12:21]

nit: sas_task_runner; the fact it's a UI TaskRunner is not relevant to this
code.

[alexeypa (please no reviews), 2012/11/01 20:56:12]

Done.

+      scoped_ptr<EventExecutor> nested_executor,
+      const base::Closure& inject_sas);

[Wez, 2012/11/01 20:12:21]

nit: Add a comment explaining that |inject_sas| will be called when Ctrl-Alt-Del
is processed, on the |sas_task_runner|.

[Wez, 2012/11/01 20:12:21]

nit: Pass the SAS TaskRunner and inject-SAS closure adjacent to one another?

[alexeypa (please no reviews), 2012/11/01 20:56:12]

Done.

[alexeypa (please no reviews), 2012/11/01 20:56:12]

Done.

   ~SessionEventExecutorWin();
 
   // EventExecutor implementation.
@@ -49,10 +52,16 @@ class SessionEventExecutorWin : public EventExecutor {
   // Pointer to the next event executor.
   scoped_ptr<EventExecutor> nested_executor_;
 
-  scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
+  scoped_refptr<base::SingleThreadTaskRunner> input_task_runner_;
+
+  scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;

[Wez, 2012/11/01 20:12:21]

nit: Consider re-ordering these wrt |nested_executor_| so their order matches
that in the ctor.

[alexeypa (please no reviews), 2012/11/01 20:56:12]

Done.

 
   ScopedThreadDesktop desktop_;
 
+  // Used to inject Secure Attention Sequence on Vista+.
+  base::Closure inject_sas_;
+
+  // Used to inject Secure Attention Sequence on XP.
   scoped_ptr<SasInjector> sas_injector_;
 
   // Keys currently pressed by the client, used to detect Ctrl-Alt-Del.