Calling SendSAS() from a service yo make sure that Secure Attention Sequence can be injected even w…

Calling SendSAS() from a service to make sure that Secure Attention Sequence can be injected even when UAC is disabled.

BUG=158625
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165565

[alexeypa (please no reviews), 2012-11-01 18:32:19]

ToT version of the fix. I tried to keep it as much close to m23 version
possible. I'm planing to refactor SAS injection code once it is fixed in
m23/m24.

[Wez, 2012-11-01 20:12:20]

LGTM w/ a couple of nits; please also correct yo->to in the description. :)

https://chromiumcodereview.appspot.com/11369024/diff/1/remoting/host/win/sess...
File remoting/host/win/session_event_executor.h (right):

https://chromiumcodereview.appspot.com/11369024/diff/1/remoting/host/win/sess...
remoting/host/win/session_event_executor.h:29:
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
nit: sas_task_runner; the fact it's a UI TaskRunner is not relevant to this
code.

https://chromiumcodereview.appspot.com/11369024/diff/1/remoting/host/win/sess...
remoting/host/win/session_event_executor.h:31: const base::Closure& inject_sas);
nit: Add a comment explaining that |inject_sas| will be called when Ctrl-Alt-Del
is processed, on the |sas_task_runner|.

https://chromiumcodereview.appspot.com/11369024/diff/1/remoting/host/win/sess...
remoting/host/win/session_event_executor.h:31: const base::Closure& inject_sas);
nit: Pass the SAS TaskRunner and inject-SAS closure adjacent to one another?

https://chromiumcodereview.appspot.com/11369024/diff/1/remoting/host/win/sess...
remoting/host/win/session_event_executor.h:57:
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
nit: Consider re-ordering these wrt |nested_executor_| so their order matches
that in the ctor.

[Wez, 2012-11-01 20:14:31]

https://chromiumcodereview.appspot.com/11369024/diff/1/remoting/host/win/sess...
File remoting/host/win/session_desktop_environment_factory.h (right):

https://chromiumcodereview.appspot.com/11369024/diff/1/remoting/host/win/sess...
remoting/host/win/session_desktop_environment_factory.h:19:
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
nit: sas_task_runner or inject_sas_task_runner

[alexeypa (please no reviews), 2012-11-01 20:56:12]

http://codereview.chromium.org/11369024/diff/1/remoting/host/win/session_even...
File remoting/host/win/session_event_executor.h (right):

http://codereview.chromium.org/11369024/diff/1/remoting/host/win/session_even...
remoting/host/win/session_event_executor.h:29:
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
On 2012/11/01 20:12:21, Wez wrote:
> nit: sas_task_runner; the fact it's a UI TaskRunner is not relevant to this
> code.

Done.

http://codereview.chromium.org/11369024/diff/1/remoting/host/win/session_even...
remoting/host/win/session_event_executor.h:31: const base::Closure& inject_sas);
On 2012/11/01 20:12:21, Wez wrote:
> nit: Add a comment explaining that |inject_sas| will be called when
Ctrl-Alt-Del
> is processed, on the |sas_task_runner|.

Done.

http://codereview.chromium.org/11369024/diff/1/remoting/host/win/session_even...
remoting/host/win/session_event_executor.h:31: const base::Closure& inject_sas);
On 2012/11/01 20:12:21, Wez wrote:
> nit: Pass the SAS TaskRunner and inject-SAS closure adjacent to one another?

Done.

http://codereview.chromium.org/11369024/diff/1/remoting/host/win/session_even...
remoting/host/win/session_event_executor.h:57:
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
On 2012/11/01 20:12:21, Wez wrote:
> nit: Consider re-ordering these wrt |nested_executor_| so their order matches
> that in the ctor.

Done.

[alexeypa (please no reviews), 2012-11-01 20:56:27]

https://chromiumcodereview.appspot.com/11369024/diff/1/remoting/host/win/sess...
File remoting/host/win/session_desktop_environment_factory.h (right):

https://chromiumcodereview.appspot.com/11369024/diff/1/remoting/host/win/sess...
remoting/host/win/session_desktop_environment_factory.h:19:
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
On 2012/11/01 20:14:31, Wez wrote:
> nit: sas_task_runner or inject_sas_task_runner

Done.

[commit-bot: I haz the power, 2012-11-01 20:57:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/11369024/2003

[commit-bot: I haz the power, 2012-11-02 00:16:06]

Change committed as 165565