chromeos: Stop exposing DriveDownloadObserver::GetDriveTempDownloadPath

chrome/browser/chromeos/drive/drive_download_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/drive/drive_download_observer.h"
 
 #include <string>
 
 #include "base/callback.h"
 #include "base/file_util.h"
@@ skipping 73 matching lines @@
   virtual ~DriveUserData() {}
 
   const FilePath& file_path() const { return file_path_; }
 
  private:
   FilePath file_path_;
 };
 
 // Extracts UploadingUserData* from |download|.
 UploadingUserData* GetUploadingUserData(DownloadItem* download) {
-  return static_cast<UploadingUserData*>(
-      download->GetUserData(&kUploadingKey));
+  return static_cast<UploadingUserData*>(download->GetUserData(&kUploadingKey));
 }
 
 const UploadingUserData* GetUploadingUserData(const DownloadItem* download) {
   return static_cast<const UploadingUserData*>(
       download->GetUserData(&kUploadingKey));
 }
 
 // Extracts DriveUserData* from |download|.
 DriveUserData* GetDriveUserData(DownloadItem* download) {
-  return static_cast<DriveUserData*>(
-      download->GetUserData(&kGDataPathKey));
+  return static_cast<DriveUserData*>(download->GetUserData(&kGDataPathKey));
 }
 
 const DriveUserData* GetDriveUserData(const DownloadItem* download) {
   return static_cast<const DriveUserData*>(
       download->GetUserData(&kGDataPathKey));
 }
 
 void RunSubstituteDriveDownloadCallback(
     const DriveDownloadObserver::SubstituteDriveDownloadPathCallback& callback,
     const FilePath* file_path) {
   callback.Run(*file_path);
 }
 
 DriveSystemService* GetSystemService(Profile* profile) {
   DriveSystemService* system_service =
       DriveSystemServiceFactory::GetForProfile(
         profile ? profile : ProfileManager::GetDefaultProfile());
   DCHECK(system_service);
   return system_service;
 }
 
+// Creates a temporary file |drive_tmp_download_path| in
+// |drive_tmp_download_dir|. Must be called on a thread that allows file
+// operations.
+void GetDriveTempDownloadPath(const FilePath& drive_tmp_download_dir,
+                              FilePath* drive_tmp_download_path) {
+  bool created = file_util::CreateDirectory(drive_tmp_download_dir);
+  DCHECK(created) << "Can not create temp download directory at "
+                  << drive_tmp_download_dir.value();
+  created = file_util::CreateTemporaryFileInDir(drive_tmp_download_dir,
+                                                drive_tmp_download_path);
+  DCHECK(created) << "Temporary download file creation failed";
+}
+
 // Substitutes virtual drive path for local temporary path.
 void SubstituteDriveDownloadPathInternal(
     Profile* profile,
     const DriveDownloadObserver::SubstituteDriveDownloadPathCallback&
         callback) {
   DVLOG(1) << "SubstituteDriveDownloadPathInternal";
 
   const FilePath drive_tmp_download_dir = GetSystemService(profile)->cache()->
       GetCacheDirectoryPath(DriveCache::CACHE_TYPE_TMP_DOWNLOADS);
 
   // Swap the drive path with a local path. Local path must be created
   // on a blocking thread.
   FilePath* drive_tmp_download_path(new FilePath());
   BrowserThread::GetBlockingPool()->PostTaskAndReply(
       FROM_HERE,
-      base::Bind(&DriveDownloadObserver::GetDriveTempDownloadPath,
+      base::Bind(&GetDriveTempDownloadPath,
                  drive_tmp_download_dir,
                  drive_tmp_download_path),
       base::Bind(&RunSubstituteDriveDownloadCallback,
                  callback,
                  base::Owned(drive_tmp_download_path)));
 }
 
 // Callback for DriveFileSystem::CreateDirectory.
 void OnCreateDirectory(
     Profile* profile,
@@ skipping 162 matching lines @@
   // count of received bytes and the size of the download as given by the
   // Content-Length header.
   int64 total = (download->AllDataSaved() ? download->GetReceivedBytes() :
                                             download->GetTotalBytes());
   DCHECK(total <= 0 || complete < total);
   if (total > 0)
     return static_cast<int>((complete * 100.0) / total);
   return -1;
 }
 
-// |drive_tmp_download_path| is set to a temporary local download path in
-// ~/GCache/v1/tmp/downloads/
-// static
-void DriveDownloadObserver::GetDriveTempDownloadPath(
-    const FilePath& drive_tmp_download_dir,
-    FilePath* drive_tmp_download_path) {
-  bool created = file_util::CreateDirectory(drive_tmp_download_dir);
-  DCHECK(created) << "Can not create temp download directory at "
-                  << drive_tmp_download_dir.value();
-  created = file_util::CreateTemporaryFileInDir(drive_tmp_download_dir,
-                                                drive_tmp_download_path);
-  DCHECK(created) << "Temporary download file creation failed";
-}
-
 void DriveDownloadObserver::ManagerGoingDown(
     DownloadManager* download_manager) {
   download_manager->RemoveObserver(this);
   download_manager_ = NULL;
 }
 
 void DriveDownloadObserver::ModelChanged(DownloadManager* download_manager) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   DownloadManager::DownloadVector downloads;
@@ skipping 376 matching lines @@
          "], file_path=[" + file_path.value() +
          "], content_type=[" + content_type +
          "], content_length=[" + base::UintToString(content_length) +
          "], upload_location=[" + upload_location.possibly_invalid_spec() +
          "], drive_path=[" + drive_path.value() +
          "], all_bytes_present=[" + (all_bytes_present ?  "true" : "false") +
          "]";
 }
 
 }  // namespace drive