Issue 11369019: chromeos: Stop exposing DriveDownloadObserver::GetDriveTempDownloadPath

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11369019: chromeos: Stop exposing DriveDownloadObserver::GetDriveTempDownloadPath (Closed)

Created:
8 years, 1 month ago by hashimoto

Modified:
8 years, 1 month ago

Reviewers:
kinaba

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Stop exposing DriveDownloadObserver::GetDriveTempDownloadPath There is no need to make the function public static when it can live in the nameless namespace. BUG=None TEST=build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165362

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -32 lines)			Patch
	M	chrome/browser/chromeos/drive/drive_download_observer.h	View		4 chunks	+7 lines, -13 lines	0 comments	Download
	M	chrome/browser/chromeos/drive/drive_download_observer.cc	View		5 chunks	+16 lines, -19 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/11369019/1

8 years, 1 month ago (2012-11-01 09:40:15 UTC) #3

commit-bot: I haz the power

Retried try job too often for step(s) interactive_ui_tests

8 years, 1 month ago (2012-11-01 11:34:24 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/11369019/1

8 years, 1 month ago (2012-11-01 13:18:14 UTC) #5

Change committed as 165362

Expand Messages | Collapse Messages