Issue 11368156: cc: Expose clear and swap on Region

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11368156: cc: Expose clear and swap on Region (Closed)

Created:
8 years, 1 month ago by enne (OOO)

Modified:
8 years, 1 month ago

Reviewers:
danakj

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Expose clear and swap on Region R=danakj@chromium.org BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166866

Patch Set 2 : nits #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -16 lines)			Patch
M	cc/layer_tree_host_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/occlusion_tracker.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	cc/region.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/region.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	cc/region_unittest.cc	View	1	3 chunks	+44 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

danakj

lgtm+nits https://codereview.chromium.org/11368156/diff/1/cc/region_unittest.cc File cc/region_unittest.cc (right): https://codereview.chromium.org/11368156/diff/1/cc/region_unittest.cc#newcode443 cc/region_unittest.cc:443: r2.ToString() Region(...).ToString() https://codereview.chromium.org/11368156/diff/1/cc/region_unittest.cc#newcode450 cc/region_unittest.cc:450: EXPECT_EQ(r2, r3); same on ...

8 years, 1 month ago (2012-11-09 00:58:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11368156/4001

8 years, 1 month ago (2012-11-09 01:01:16 UTC) #3

Change committed as 166866

Expand Messages | Collapse Messages

Issue 11368156: cc: Expose clear and swap on Region (Closed)

Description

Patch Set 1 #

Patch Set 2 : nits #

Messages