Disable scissor test during texture copies

Disable scissor test during texture copies


BUG=160075
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166835

[danakj, 2012-11-08 22:42:40]

I see we have a similar situation for linear filtering. ok lgtm

When we stop setting scissor on every frame, can we make sure to DCHECK() that
it is on?

[commit-bot: I haz the power, 2012-11-08 23:28:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/11368152/1

[jamesr, 2012-11-08 23:29:32]

On 2012/11/08 22:42:40, danakj wrote:
> I see we have a similar situation for linear filtering. ok lgtm
> 
> When we stop setting scissor on every frame, can we make sure to DCHECK() that
> it is on?

We should do something - I'm a little worried that doing a glGet() in a DCHECK
will be too slow even for debug since it fully serializes the processes.  We
could have something like the GLC macro cover this

[enne (OOO), 2012-11-09 00:55:55]

On 2012/11/08 23:29:32, jamesr wrote:
> On 2012/11/08 22:42:40, danakj wrote:
> > I see we have a similar situation for linear filtering. ok lgtm
> > 
> > When we stop setting scissor on every frame, can we make sure to DCHECK()
that
> > it is on?
> 
> We should do something - I'm a little worried that doing a glGet() in a DCHECK
> will be too slow even for debug since it fully serializes the processes.  We
> could have something like the GLC macro cover this

I think unit tests could also do the job if we have coverage of all the quad
drawing functions without resorting to glGet.

[commit-bot: I haz the power, 2012-11-09 01:38:46]

Change committed as 166835