Issue 11368148: Revert r166725 "Enforce 15 minutes timeout for all operations and 30 minutes..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11368148: Revert r166725 "Enforce 15 minutes timeout for all operations and 30 minutes..." (Closed)

Created:
8 years, 1 month ago by M-A Ruel

Modified:
8 years, 1 month ago

Reviewers:
Peter Mayo

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Revert r166725 "Enforce 15 minutes timeout for all operations and 30 minutes..." This causes an excepiton on Windows, File "E:\b\depot_tools\subprocess2.py", line 341, in communicate TypeError: Using timeout and shell simultaneously will cause a process leak since the shell will be killed instead of the child process. TBR=petermayo@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166732

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -34 lines)			Patch
	M	checkout.py	View		9 chunks	+11 lines, -34 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/11368148/1

8 years, 1 month ago (2012-11-08 19:34:34 UTC) #2

Change committed as 166732

Expand Messages | Collapse Messages