Prevented default apps from being installed in ChromeOS tests

Prevented default apps from being installed in ChromeOS tests

BUG=chromium-os:36058
TEST=make sure pyauto BVTs are happy on chromeos bbots


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167029

[DaveMoore, 2012-11-08 02:11:08]

lgtm

[dpolukhin, 2012-11-08 02:25:33]

https://codereview.chromium.org/11368129/diff/1/chrome/test/pyautolib/pyauto.py
File chrome/test/pyautolib/pyauto.py (right):

https://codereview.chromium.org/11368129/diff/1/chrome/test/pyautolib/pyauto....
chrome/test/pyautolib/pyauto.py:286: '--disable-default-apps',
Unfortunately it looks like it won't help because on Chrome OS default apps as
external extensions. I suspect that this flag will only affect default apps for
desktop  (will check it tomorrow). See chrome/browser/extensions/default_apps.cc
Provider::ShouldInstallInProfile.

[zel, 2012-11-08 04:37:46]

https://codereview.chromium.org/11368129/diff/1/chrome/test/pyautolib/pyauto.py
File chrome/test/pyautolib/pyauto.py (right):

https://codereview.chromium.org/11368129/diff/1/chrome/test/pyautolib/pyauto....
chrome/test/pyautolib/pyauto.py:286: '--disable-default-apps',
On 2012/11/08 02:25:34, dpolukhin wrote:
> Unfortunately it looks like it won't help because on Chrome OS default apps as
> external extensions. I suspect that this flag will only affect default apps
for
> desktop  (will check it tomorrow). See
chrome/browser/extensions/default_apps.cc
> Provider::ShouldInstallInProfile.

Can we change chromeos-specific install to start obeying this flag too? Where
does this code reside now?

[Dmitry Polukhin, 2012-11-08 13:34:43]

https://codereview.chromium.org/11368129/diff/1/chrome/test/pyautolib/pyauto.py
File chrome/test/pyautolib/pyauto.py (right):

https://codereview.chromium.org/11368129/diff/1/chrome/test/pyautolib/pyauto....
chrome/test/pyautolib/pyauto.py:286: '--disable-default-apps',
On 2012/11/08 04:37:46, zel wrote:
> Can we change chromeos-specific install to start obeying this flag too? Where
> does this code reside now?

The code is in ExternalProviderImpl::CreateExternalProviders. Basically we need
to skip external providers registration if this flag set (it should be good
thing to do anyway). I'll try to make this change, I hope it won't break
extensions tests.

[Dmitry Polukhin, 2012-11-08 16:28:13]

https://codereview.chromium.org/11368129/diff/1/chrome/test/pyautolib/pyauto.py
File chrome/test/pyautolib/pyauto.py (right):

https://codereview.chromium.org/11368129/diff/1/chrome/test/pyautolib/pyauto....
chrome/test/pyautolib/pyauto.py:286: '--disable-default-apps',
On 2012/11/08 13:34:43, Dmitry Polukhin wrote:
> The code is in ExternalProviderImpl::CreateExternalProviders. Basically we
need
> to skip external providers registration if this flag set (it should be good
> thing to do anyway). I'll try to make this change, I hope it won't break
> extensions tests.

CL is here https://codereview.chromium.org/11359105/ but I need to fix tests
before committing it.

[commit-bot: I haz the power, 2012-11-09 21:49:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/11368129/1

[commit-bot: I haz the power, 2012-11-09 21:49:12]

Presubmit check for 11368129-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/test/pyautolib

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[dennis_jeffrey, 2012-11-09 22:05:08]

LGTM

[commit-bot: I haz the power, 2012-11-09 22:49:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/11368129/1

[commit-bot: I haz the power, 2012-11-10 01:31:42]

Change committed as 167029