Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 11368122: Export the build type as part of Android's build bot baseline setup (Closed)

Created:
8 years, 1 month ago by Peter Beverloo
Modified:
8 years, 1 month ago
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Export the build type as part of Android's build bot baseline setup The WebKit tester builds in release mode, which we need to tell the run_tests.py script about. Otherwise it'll assume a debug build, causing it to be unable to find the webkit_unit_tests and TestWebKitAPI APKs. BUG=136774 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166519

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M build/android/buildbot/buildbot_functions.sh View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Peter Beverloo
+cjhopman, ilevy Example log file (search for "bb_run_webkit_unit_tests"): http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28GalaxyNexus%29/builds/961/steps/update/logs/stdio This seems cleaner than passing either ...
8 years, 1 month ago (2012-11-07 18:20:42 UTC) #1
Peter Beverloo
8 years, 1 month ago (2012-11-07 18:21:31 UTC) #2
Isaac (away)
I think it is preferable to add a --buildtype $BUILDTYPE argument for run_tests. I do ...
8 years, 1 month ago (2012-11-07 18:40:40 UTC) #3
Peter Beverloo
On 2012/11/07 18:40:40, Isaac wrote: > I think it is preferable to add a --buildtype ...
8 years, 1 month ago (2012-11-07 19:10:54 UTC) #4
Isaac (away)
lgtm
8 years, 1 month ago (2012-11-07 19:13:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/11368122/5001
8 years, 1 month ago (2012-11-07 19:16:39 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-07 21:12:09 UTC) #7
Change committed as 166519

Powered by Google App Engine
This is Rietveld 408576698