Make sure we build the tools used for testing minidumps on Android.

Make sure we build the tools used for testing minidumps on Android.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166377

[Yaron, 2012-11-06 22:38:43]

https://codereview.chromium.org/11368111/diff/1/build/all_android.gyp
File build/all_android.gyp (right):

https://codereview.chromium.org/11368111/diff/1/build/all_android.gyp#newcode98
build/all_android.gyp:98: 'target_name': 'minidump_tools',
Should the definition of this target be defined only for linux_breakpad=1?
Actually, this might be helpful.. it means that you can build the minidump_tools
target without linux_breakpad=1, right? Just want to make sure this doesn't
break the regular workflow which defaults to "All" and doesn't include this?

[Jay Civelli, 2012-11-06 22:54:47]

https://codereview.chromium.org/11368111/diff/1/build/all_android.gyp
File build/all_android.gyp (right):

https://codereview.chromium.org/11368111/diff/1/build/all_android.gyp#newcode98
build/all_android.gyp:98: 'target_name': 'minidump_tools',
On 2012/11/06 22:38:43, Yaron wrote:
> Should the definition of this target be defined only for linux_breakpad=1?
> Actually, this might be helpful.. it means that you can build the
minidump_tools
> target without linux_breakpad=1, right? Just want to make sure this doesn't
> break the regular workflow which defaults to "All" and doesn't include this?
Yes, I think it might be helpful for the case you described.
I am not sure I am following you on how this could break the All workflow. These
were not built before for All, and still won't unless linux_breakpad is 1,
right?

[Yaron, 2012-11-06 23:09:20]

lgtm

[Jay Civelli, 2012-11-07 01:17:58]

Fixed on non linux_breakpad.
PTAL

[Yaron, 2012-11-07 02:09:57]

lgtm

[commit-bot: I haz the power, 2012-11-07 06:34:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jcivelli@chromium.org/11368111/5

[commit-bot: I haz the power, 2012-11-07 10:18:58]

Change committed as 166377