Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 11368108: Convert NetworkState to IDL. (Closed)

Created:
8 years, 1 month ago by teravest
Modified:
8 years, 1 month ago
CC:
chromium-reviews, yusukes+watch_chromium.org, raymes+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Convert NetworkState to IDL. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166486

Patch Set 1 #

Patch Set 2 : Fixed macro name for interface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -14 lines) Patch
A + ppapi/api/dev/ppp_network_state_dev.idl View 1 2 chunks +7 lines, -9 lines 0 comments Download
M ppapi/c/dev/ppp_network_state_dev.h View 1 2 chunks +23 lines, -4 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 7 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
teravest
8 years, 1 month ago (2012-11-06 21:26:55 UTC) #1
dmichael (off chromium)
lgtm Make sure you do a try run (git cl try); this change could affect ...
8 years, 1 month ago (2012-11-06 21:30:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/11368108/1
8 years, 1 month ago (2012-11-07 15:17:56 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-07 15:30:22 UTC) #4
teravest
Added a macro attribute to fix the build breakage in patch set 1.
8 years, 1 month ago (2012-11-07 17:19:57 UTC) #5
dmichael (off chromium)
lgtm
8 years, 1 month ago (2012-11-07 17:24:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/11368108/6
8 years, 1 month ago (2012-11-07 17:27:31 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-11-07 19:26:53 UTC) #8
Change committed as 166486

Powered by Google App Engine
This is Rietveld 408576698