chrome/browser/extensions/extension_prefs_unittest.cc - Issue 11368098: Draft change to use base::Closure instead of PrefObserver in PrefChangeRegistrar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_prefs_unittest.cc

Issue 11368098: Draft change to use base::Closure instead of PrefObserver in PrefChangeRegistrar. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Respond to review comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_prefs_unittest.cc

diff --git a/chrome/browser/extensions/extension_prefs_unittest.cc b/chrome/browser/extensions/extension_prefs_unittest.cc

index 55a52cb1a690655c51a57e0d08f9ee90cb5568cc..82b912ab2c4c29f2e902f4c1f312a98d5ff3c4f6 100644

--- a/chrome/browser/extensions/extension_prefs_unittest.cc

+++ b/chrome/browser/extensions/extension_prefs_unittest.cc

@@ -1126,8 +1126,8 @@ class ExtensionPrefsNotifyWhenNeeded : public ExtensionPrefsPrepopulatedTest {

Mock::VerifyAndClearExpectations(&observer);

Mock::VerifyAndClearExpectations(&incognito_observer);

- registrar.Remove(kPref1, &observer);

- incognito_registrar.Remove(kPref1, &incognito_observer);

+ registrar.Remove(kPref1);

+ incognito_registrar.Remove(kPref1);

}

virtual void Verify() {

std::string actual = prefs()->pref_service()->GetString(kPref1);

« no previous file with comments | « chrome/browser/api/prefs/pref_member.cc ('k') | chrome/browser/prefs/pref_service_unittest.cc » ('j') | no next file with comments »