Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: chrome/browser/api/prefs/pref_member.cc

Issue 11368098: Draft change to use base::Closure instead of PrefObserver in PrefChangeRegistrar. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to review comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/api/prefs/pref_member.h" 5 #include "chrome/browser/api/prefs/pref_member.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind_helpers.h"
8 #include "base/callback.h"
8 #include "base/location.h" 9 #include "base/location.h"
9 #include "base/prefs/public/pref_service_base.h" 10 #include "base/prefs/public/pref_service_base.h"
10 #include "base/value_conversions.h" 11 #include "base/value_conversions.h"
11 12
12 using base::MessageLoopProxy; 13 using base::MessageLoopProxy;
13 14
14 namespace subtle { 15 namespace subtle {
15 16
16 PrefMemberBase::PrefMemberBase() 17 PrefMemberBase::PrefMemberBase()
17 : observer_(NULL), 18 : observer_(base::Bind(&base::DoNothing)),
18 prefs_(NULL), 19 prefs_(NULL),
19 setting_value_(false) { 20 setting_value_(false) {
20 } 21 }
21 22
22 PrefMemberBase::~PrefMemberBase() { 23 PrefMemberBase::~PrefMemberBase() {
23 Destroy(); 24 Destroy();
24 } 25 }
25 26
26 void PrefMemberBase::Init(const char* pref_name, 27 void PrefMemberBase::Init(const char* pref_name,
27 PrefServiceBase* prefs, 28 PrefServiceBase* prefs,
28 PrefObserver* observer) { 29 const base::Closure& observer) {
30 observer_ = observer;
31 Init(pref_name, prefs);
32 }
33
34 void PrefMemberBase::Init(const char* pref_name,
35 PrefServiceBase* prefs) {
29 DCHECK(pref_name); 36 DCHECK(pref_name);
30 DCHECK(prefs); 37 DCHECK(prefs);
31 DCHECK(pref_name_.empty()); // Check that Init is only called once. 38 DCHECK(pref_name_.empty()); // Check that Init is only called once.
32 observer_ = observer;
33 prefs_ = prefs; 39 prefs_ = prefs;
34 pref_name_ = pref_name; 40 pref_name_ = pref_name;
35 // Check that the preference is registered. 41 // Check that the preference is registered.
36 DCHECK(prefs_->FindPreference(pref_name_.c_str())) 42 DCHECK(prefs_->FindPreference(pref_name_.c_str()))
37 << pref_name << " not registered."; 43 << pref_name << " not registered.";
38 44
39 // Add ourselves as a pref observer so we can keep our local value in sync. 45 // Add ourselves as a pref observer so we can keep our local value in sync.
40 prefs_->AddPrefObserver(pref_name, this); 46 prefs_->AddPrefObserver(pref_name, this);
41 } 47 }
42 48
(...skipping 10 matching lines...) Expand all
53 // Load the value from preferences if it hasn't been loaded so far. 59 // Load the value from preferences if it hasn't been loaded so far.
54 if (!internal()) 60 if (!internal())
55 UpdateValueFromPref(); 61 UpdateValueFromPref();
56 internal()->MoveToThread(message_loop); 62 internal()->MoveToThread(message_loop);
57 } 63 }
58 64
59 void PrefMemberBase::OnPreferenceChanged(PrefServiceBase* service, 65 void PrefMemberBase::OnPreferenceChanged(PrefServiceBase* service,
60 const std::string& pref_name) { 66 const std::string& pref_name) {
61 VerifyValuePrefName(); 67 VerifyValuePrefName();
62 UpdateValueFromPref(); 68 UpdateValueFromPref();
63 if (!setting_value_ && observer_) 69 if (!setting_value_)
64 observer_->OnPreferenceChanged(service, pref_name); 70 observer_.Run();
65 } 71 }
66 72
67 void PrefMemberBase::UpdateValueFromPref() const { 73 void PrefMemberBase::UpdateValueFromPref() const {
68 VerifyValuePrefName(); 74 VerifyValuePrefName();
69 const PrefServiceBase::Preference* pref = 75 const PrefServiceBase::Preference* pref =
70 prefs_->FindPreference(pref_name_.c_str()); 76 prefs_->FindPreference(pref_name_.c_str());
71 DCHECK(pref); 77 DCHECK(pref);
72 if (!internal()) 78 if (!internal())
73 CreateInternal(); 79 CreateInternal();
74 internal()->UpdateValue(pref->GetValue()->DeepCopy(), 80 internal()->UpdateValue(pref->GetValue()->DeepCopy(),
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 ListValue list_value; 203 ListValue list_value;
198 list_value.AppendStrings(value); 204 list_value.AppendStrings(value);
199 prefs()->Set(pref_name().c_str(), list_value); 205 prefs()->Set(pref_name().c_str(), list_value);
200 } 206 }
201 207
202 template <> 208 template <>
203 bool PrefMember<std::vector<std::string> >::Internal::UpdateValueInternal( 209 bool PrefMember<std::vector<std::string> >::Internal::UpdateValueInternal(
204 const Value& value) const { 210 const Value& value) const {
205 return subtle::PrefMemberVectorStringUpdate(value, &value_); 211 return subtle::PrefMemberVectorStringUpdate(value, &value_);
206 } 212 }
OLDNEW
« no previous file with comments | « chrome/browser/api/prefs/pref_member.h ('k') | chrome/browser/extensions/extension_prefs_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698