aura: Add flag to indicate if a drag session is started with touch or mouse.

aura: Add flag to indicate if a drag session is started with touch or mouse.

BUG=114755
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166278

[sky, 2012-11-05 15:57:40]

Could we use an enum rather than a boolean?

[varunjain, 2012-11-05 17:25:13]

On 2012/11/05 15:57:40, sky wrote:
> Could we use an enum rather than a boolean?

Done.

[sky, 2012-11-05 18:13:56]

https://codereview.chromium.org/11368072/diff/4002/content/browser/web_conten...
File content/browser/web_contents/web_contents_view_aura.cc (right):

https://codereview.chromium.org/11368072/diff/4002/content/browser/web_conten...
content/browser/web_contents/web_contents_view_aura.cc:469:
ui::DragDropTypes::DRAG_EVENT_SOURCE_MOUSE);
Do we know this is always from a mouse event?

https://codereview.chromium.org/11368072/diff/4002/ui/views/controls/menu/men...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/11368072/diff/4002/ui/views/controls/menu/men...
ui/views/controls/menu/menu_controller.cc:867:
ui::DragDropTypes::DRAG_EVENT_SOURCE_MOUSE);
Don't we use this path for touch dragging too? I suspect on windows we could hit
this for touch.

https://codereview.chromium.org/11368072/diff/4002/ui/views/view.cc
File ui/views/view.cc (right):

https://codereview.chromium.org/11368072/diff/4002/ui/views/view.cc#newcode1967
ui/views/view.cc:1967: ui::DragDropTypes::DRAG_EVENT_SOURCE_MOUSE);
On windows we map touch events to mosue events. See EF_FROM_TOUCH.

[varunjain, 2012-11-05 18:25:49]

https://codereview.chromium.org/11368072/diff/4002/content/browser/web_conten...
File content/browser/web_contents/web_contents_view_aura.cc (right):

https://codereview.chromium.org/11368072/diff/4002/content/browser/web_conten...
content/browser/web_contents/web_contents_view_aura.cc:469:
ui::DragDropTypes::DRAG_EVENT_SOURCE_MOUSE);
On 2012/11/05 18:13:56, sky wrote:
> Do we know this is always from a mouse event?

No. In a followup CL, I plan to patch this information through from the
renderer.

https://codereview.chromium.org/11368072/diff/4002/ui/views/controls/menu/men...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/11368072/diff/4002/ui/views/controls/menu/men...
ui/views/controls/menu/menu_controller.cc:867:
ui::DragDropTypes::DRAG_EVENT_SOURCE_MOUSE);
On 2012/11/05 18:13:56, sky wrote:
> Don't we use this path for touch dragging too? I suspect on windows we could
hit
> this for touch.

Even if we do, this should not change the behavior as it currently is. I have
followup CL(s) to properly enable touch dragging which will use this flag. I
will update this value accordingly in those CLs.

https://codereview.chromium.org/11368072/diff/4002/ui/views/view.cc
File ui/views/view.cc (right):

https://codereview.chromium.org/11368072/diff/4002/ui/views/view.cc#newcode1967
ui/views/view.cc:1967: ui::DragDropTypes::DRAG_EVENT_SOURCE_MOUSE);
On 2012/11/05 18:13:56, sky wrote:
> On windows we map touch events to mosue events. See EF_FROM_TOUCH.

I have not used the source value in any windows drag drop code. The purpose of
this CL is to simply plumb the event source through to the drag_drop_controller.
It should not change any existing functionality. Is that not the case?

[sky, 2012-11-05 21:51:56]

https://codereview.chromium.org/11368072/diff/4002/ui/views/view.cc
File ui/views/view.cc (right):

https://codereview.chromium.org/11368072/diff/4002/ui/views/view.cc#newcode1967
ui/views/view.cc:1967: ui::DragDropTypes::DRAG_EVENT_SOURCE_MOUSE);
On 2012/11/05 18:25:49, varunjain wrote:
> On 2012/11/05 18:13:56, sky wrote:
> > On windows we map touch events to mosue events. See EF_FROM_TOUCH.
> 
> I have not used the source value in any windows drag drop code. The purpose of
> this CL is to simply plumb the event source through to the
drag_drop_controller.
> It should not change any existing functionality. Is that not the case?

Certainly. But don't we want to send the right value? Otherwise what's the
point?

[sky, 2012-11-05 22:02:23]

Varun is going to add a TODO. So, LGTM

[varunjain, 2012-11-06 00:05:44]

On 2012/11/05 22:02:23, sky wrote:
> Varun is going to add a TODO. So, LGTM

Hi Scott.. added the TODOs and also changed the CL to also pass the aura::Window
that is the source of the drag drop session. PTAL.

[sky, 2012-11-06 00:05:52]

LGTM

[commit-bot: I haz the power, 2012-11-06 19:10:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/11368072/7004

[commit-bot: I haz the power, 2012-11-06 20:04:05]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-06 20:06:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/11368072/7004

[commit-bot: I haz the power, 2012-11-06 22:03:02]

Change committed as 166278