Chromium Code Reviews
Help | Chromium Project | Sign in
(753)

Issue 11368040: Introduce RemoveChromeTaskbarShortcuts() to delete all pinned-to-taskbar shortcuts owned by the uni… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by gab
Modified:
1 year, 5 months ago
Reviewers:
brettw, robertshield
CC:
chromium-reviews_chromium.org, grt+watch_chromium.org, erikwright+watch_chromium.org, erikwright, huangs1
Visibility:
Public.

Description

Re-commit: Introduce RemoveChromeTaskbarShortcuts() to delete all pinned-to-taskbar shortcuts owned by the uninstalled Chrome.

Original commit http://crrev.com/165505
Reverted in http://crrev.com/165524

BUG=158632
TEST=No user-level shortcut Chrome left behind in taskbar post user-level self-destruct.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166285

Patch Set 1 #

Patch Set 2 : fixed XP (no taskbar shortcuts on XP/Vista... #

Patch Set 3 : compile... #

Patch Set 4 : fix closing bracket #

Patch Set 5 : dear robert@garage #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -15 lines) Lint Patch
M base/base_paths_win.h View 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
M base/base_paths_win.cc View 1 chunk +6 lines, -0 lines 0 comments 0 errors Download
M base/path_service_unittest.cc View 1 2 3 4 1 chunk +22 lines, -13 lines 1 comment 1 errors Download
M chrome/browser/shell_integration_win.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M chrome/installer/setup/uninstall.cc View 1 chunk +7 lines, -0 lines 0 comments ? errors Download
M chrome/installer/util/shell_util.h View 1 chunk +7 lines, -0 lines 0 comments ? errors Download
M chrome/installer/util/shell_util.cc View 1 2 3 4 1 chunk +31 lines, -0 lines 1 comment ? errors Download
Commit:

Messages

Total messages: 11
gab
Sir, PTAL.
1 year, 5 months ago #1
robertshield
On 2012/11/01 22:36:02, gab wrote: > Sir, PTAL. The trybots are unhappy with this: e:\b\build\slave\win\build\src\base\path_service_unittest.cc(61) ...
1 year, 5 months ago #2
gab
On 2012/11/02 00:13:20, robertshield wrote: > On 2012/11/01 22:36:02, gab wrote: > > Sir, PTAL. ...
1 year, 5 months ago #3
gab
ping (see reply above).
1 year, 5 months ago #4
gab
Comments (sent over IM) addressed.
1 year, 5 months ago #5
robertshield
lgtm http://codereview.chromium.org/11368040/diff/14001/base/path_service_unittest.cc File base/path_service_unittest.cc (right): http://codereview.chromium.org/11368040/diff/14001/base/path_service_unittest.cc#newcode65 base/path_service_unittest.cc:65: file_util::PathExists(path)); nice :)
1 year, 5 months ago #6
gab
@brettw: this is a re-commit of a reverted CL which you originally LGTMed (see diff ...
1 year, 5 months ago #7
brettw
lgtm http://codereview.chromium.org/11368040/diff/14001/chrome/installer/util/shell_util.cc File chrome/installer/util/shell_util.cc (right): http://codereview.chromium.org/11368040/diff/14001/chrome/installer/util/shell_util.cc#newcode1871 chrome/installer/util/shell_util.cc:1871: LOG(ERROR) << "Couldn't resolve shortcut at " << ...
1 year, 5 months ago #8
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/11368040/14001
1 year, 5 months ago #9
brettw
You can keep LOG for consistency.
1 year, 5 months ago #10
I haz the power (commit-bot)
1 year, 5 months ago #11
Change committed as 166285
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434