Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1475)

Issue 11368035: crypto: Remove forbidden using namespace directive. (Closed)

Created:
8 years, 1 month ago by tfarina
Modified:
8 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

crypto: Remove forbidden using namespace directive. Instead just wrap the unittests files into the crypto namespace. TEST=crypto_unittests R=rsleevi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165816

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M crypto/p224_spake_unittest.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M crypto/p224_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
tfarina
Hi Ryan, could you review this to me?
8 years, 1 month ago (2012-11-01 18:36:23 UTC) #1
Ryan Sleevi
lgtm
8 years, 1 month ago (2012-11-02 07:42:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11368035/1
8 years, 1 month ago (2012-11-02 12:15:20 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) content_browsertests
8 years, 1 month ago (2012-11-02 13:42:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11368035/1
8 years, 1 month ago (2012-11-02 14:40:01 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 1 month ago (2012-11-02 15:03:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11368035/1
8 years, 1 month ago (2012-11-02 16:45:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11368035/1
8 years, 1 month ago (2012-11-03 00:11:19 UTC) #8
commit-bot: I haz the power
8 years, 1 month ago (2012-11-03 00:48:19 UTC) #9
Change committed as 165816

Powered by Google App Engine
This is Rietveld 408576698