Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: src/trusted/service_runtime/arch/mips/sel_rt.h

Issue 11368024: [MIPS] Restore the trusted stack in NaClSyscallSeg. (Closed) Base URL: http://git.chromium.org/native_client/src/native_client.git@master
Patch Set: Remove saving of $gp. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/service_runtime/arch/mips/sel_rt.h
diff --git a/src/trusted/service_runtime/arch/mips/sel_rt.h b/src/trusted/service_runtime/arch/mips/sel_rt.h
index 04e8c4032a77f13b57a3f807c8861e295a2a559a..6ba4fb9c434ec265fa64ef1af7419bf32b4f987a 100644
--- a/src/trusted/service_runtime/arch/mips/sel_rt.h
+++ b/src/trusted/service_runtime/arch/mips/sel_rt.h
@@ -39,8 +39,8 @@ struct NaClThreadContext {
nacl_reg_t s0, s1, s2, s3, s4, s5, s6, s7, t8;
/* 0 4 8 c 10 14 18 1c 20 */
- nacl_reg_t global_ptr, stack_ptr, frame_ptr, prog_ctr;
- /* 24 28 2c 30 */
+ nacl_reg_t stack_ptr, frame_ptr, prog_ctr;
+ /* 24 28 2c */
/*
* sys_ret and new_prog_ctr are not a part of the thread's register set,
@@ -48,15 +48,15 @@ struct NaClThreadContext {
* use the same interface.
*/
uint32_t sysret;
- /* 34 */
+ /* 30 */
uint32_t new_prog_ctr;
- /* 38 */
+ /* 34 */
uint32_t trusted_stack_ptr;
- /* 3c */
+ /* 38 */
uint32_t tls_idx;
- /* 40 */
+ /* 3c */
uint32_t tls_value2;
- /* 44 */
+ /* 40 */
};
#endif /* !defined(__ASSEMBLER__) */
@@ -70,15 +70,14 @@ struct NaClThreadContext {
#define NACL_THREAD_CONTEXT_OFFSET_S6 0x18
#define NACL_THREAD_CONTEXT_OFFSET_S7 0x1c
#define NACL_THREAD_CONTEXT_OFFSET_T8 0x20
-#define NACL_THREAD_CONTEXT_OFFSET_GLOBAL_PTR 0x24
-#define NACL_THREAD_CONTEXT_OFFSET_STACK_PTR 0x28
-#define NACL_THREAD_CONTEXT_OFFSET_FRAME_PTR 0x2c
-#define NACL_THREAD_CONTEXT_OFFSET_PROG_CTR 0x30
-#define NACL_THREAD_CONTEXT_OFFSET_SYSRET 0x34
-#define NACL_THREAD_CONTEXT_OFFSET_NEW_PROG_CTR 0x38
-#define NACL_THREAD_CONTEXT_OFFSET_TRUSTED_STACK_PTR 0x3c
-#define NACL_THREAD_CONTEXT_OFFSET_TLS_IDX 0x40
-#define NACL_THREAD_CONTEXT_OFFSET_TLS_VALUE2 0x44
+#define NACL_THREAD_CONTEXT_OFFSET_STACK_PTR 0x24
+#define NACL_THREAD_CONTEXT_OFFSET_FRAME_PTR 0x28
+#define NACL_THREAD_CONTEXT_OFFSET_PROG_CTR 0x2c
+#define NACL_THREAD_CONTEXT_OFFSET_SYSRET 0x30
+#define NACL_THREAD_CONTEXT_OFFSET_NEW_PROG_CTR 0x34
+#define NACL_THREAD_CONTEXT_OFFSET_TRUSTED_STACK_PTR 0x38
+#define NACL_THREAD_CONTEXT_OFFSET_TLS_IDX 0x3c
+#define NACL_THREAD_CONTEXT_OFFSET_TLS_VALUE2 0x40
#if !defined(__ASSEMBLER__)
@@ -105,7 +104,6 @@ static INLINE void NaClThreadContextOffsetCheck(void) {
NACL_CHECK_FIELD(NACL_THREAD_CONTEXT_OFFSET_S6, s6);
NACL_CHECK_FIELD(NACL_THREAD_CONTEXT_OFFSET_S7, s7);
NACL_CHECK_FIELD(NACL_THREAD_CONTEXT_OFFSET_T8, t8);
- NACL_CHECK_FIELD(NACL_THREAD_CONTEXT_OFFSET_GLOBAL_PTR, global_ptr);
NACL_CHECK_FIELD(NACL_THREAD_CONTEXT_OFFSET_STACK_PTR, stack_ptr);
NACL_CHECK_FIELD(NACL_THREAD_CONTEXT_OFFSET_FRAME_PTR, frame_ptr);
NACL_CHECK_FIELD(NACL_THREAD_CONTEXT_OFFSET_PROG_CTR, prog_ctr);
@@ -118,7 +116,6 @@ static INLINE void NaClThreadContextOffsetCheck(void) {
CHECK(offset == sizeof(struct NaClThreadContext));
#undef NACL_CHECK_FIELD
-
}
#endif /* !defined(__ASSEMBLER__) */

Powered by Google App Engine
This is Rietveld 408576698