Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: content/common/view_messages.h

Issue 11368019: Add support for external out-of-process PPAPI plugins in the browser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_message_filter.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/view_messages.h
===================================================================
--- content/common/view_messages.h (revision 166155)
+++ content/common/view_messages.h (working copy)
@@ -1947,27 +1947,29 @@
IPC::ChannelHandle /* handle to channel */,
int /* plugin_child_id */)
-// Notification that a native (non-NaCl) plugin has created a new plugin
-// instance. The parameters indicate the plugin process ID that we're creating
-// the instance for, and the routing ID of the render view that the plugin
-// instance is associated with. This allows us to create a mapping in the
-// browser process for what objects a given PP_Instance is associated with.
+// Notification that a plugin has created a new plugin instance. The parameters
+// indicate the plugin process ID that we're creating the instance for, and the
+// routing ID of the render view that the plugin instance is associated with.
+// This allows us to create a mapping in the browser process for what objects a
+// given PP_Instance is associated with.
//
// This message must be sync even though it returns no parameters to avoid
// a race condition with the plugin process. The plugin process sends messages
// to the browser that assume the browser knows about the instance. We need to
-// sure that the browser actually knows about the instance before we tell the
-// plugin to run.
-IPC_SYNC_MESSAGE_CONTROL3_0(ViewHostMsg_DidCreateOutOfProcessPepperInstance,
+// make sure that the browser actually knows about the instance before we tell
+// the plugin to run.
+IPC_SYNC_MESSAGE_CONTROL4_0(ViewHostMsg_DidCreateOutOfProcessPepperInstance,
int /* plugin_child_id */,
int32 /* pp_instance */,
- int /* view_routing_id */)
+ int /* view_routing_id */,
+ bool /* is_external */)
-// Notification that a native (non-NaCl) plugin has destroyed an instance. This
-// is the opposite if the "DidCreate" version above.
-IPC_MESSAGE_CONTROL2(ViewHostMsg_DidDeleteOutOfProcessPepperInstance,
+// Notification that a plugin has destroyed an instance. This is the opposite of
+// the "DidCreate" message above.
+IPC_MESSAGE_CONTROL3(ViewHostMsg_DidDeleteOutOfProcessPepperInstance,
int /* plugin_child_id */,
- int32 /* pp_instance */)
+ int32 /* pp_instance */,
+ bool /* is_external */)
// A renderer sends this to the browser process when it wants to
// create a ppapi broker. The browser will create the broker process
« no previous file with comments | « content/browser/renderer_host/render_message_filter.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698