Add support for external out-of-process PPAPI plugins in the browser.

Add support for external out-of-process PPAPI plugins in the browser.
- Modifies content::BrowserPpapiHostImpl so it's not ref-counted.
- Adds a public content API method, BrowserPpapiHost::CreateExternalPluginProcess
  which allows the embedder to associate a browser ppapi host with a plugin process.
- Adds a public content API method, ContentBrowserClient::GetExternalBrowserPpapiHost,
  so content can track instance creation and deletion for external plugins (e.g. NaCl)
- Removes the content API method EnablePepperSupportForChannel. This is now done
  when creating the BrowserPpapiHost.
BUG=116317
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166480

[bbudge, 2012-10-31 23:05:14]

I haven't actually run this yet to test.

I took your advice and added an 'is_external' flag to the view host messages,
and modified ContentBrowserClient so we can get a BrowserPpapiHost for an
external plugin process.

http://codereview.chromium.org/11368019/diff/2005/content/renderer/pepper/pep...
File content/renderer/pepper/pepper_plugin_delegate_impl.cc (left):

http://codereview.chromium.org/11368019/diff/2005/content/renderer/pepper/pep...
content/renderer/pepper/pepper_plugin_delegate_impl.cc:460: permissions,
Removed unused parameter. It's passed in the ctor.

[bbudge, 2012-11-06 23:07:03]

Updated the patch. This seems to work, so ready for review. PTAL

[brettw, 2012-11-07 00:18:11]

http://codereview.chromium.org/11368019/diff/2015/content/browser/renderer_ho...
File content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc (right):

http://codereview.chromium.org/11368019/diff/2015/content/browser/renderer_ho...
content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc:16: IPC::Sender*
sender,
Nit: should only be indented 4 spaces.

http://codereview.chromium.org/11368019/diff/2015/content/browser/renderer_ho...
content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc:109: return
ppapi_host_->OnMessageReceived(msg);
Don't forget to null check this when you add the nulling in
~BrowserPpapiHostIMpl

http://codereview.chromium.org/11368019/diff/2015/content/browser/renderer_ho...
File content/browser/renderer_host/pepper/browser_ppapi_host_impl.h (right):

http://codereview.chromium.org/11368019/diff/2015/content/browser/renderer_ho...
content/browser/renderer_host/pepper/browser_ppapi_host_impl.h:75:
ppapi::host::PpapiHost* ppapi_host_;
You should have a way for this back pointer to be nulled out and do this in the
BrowserPpapiHost destructor. This filter may outlive your class, so you should
always check the pointer nullness before dispatching.

http://codereview.chromium.org/11368019/diff/2015/content/public/browser/cont...
File content/public/browser/content_browser_client.h (right):

http://codereview.chromium.org/11368019/diff/2015/content/public/browser/cont...
content/public/browser/content_browser_client.h:450: virtual void
DidCreatePpapiInstance(int plugin_child_id,
I'm not sure these are used? Are they from a previous patch?

[bbudge, 2012-11-07 00:51:45]

Addressed comments.

http://codereview.chromium.org/11368019/diff/2015/content/browser/renderer_ho...
File content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc (right):

http://codereview.chromium.org/11368019/diff/2015/content/browser/renderer_ho...
content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc:16: IPC::Sender*
sender,
On 2012/11/07 00:18:11, brettw wrote:
> Nit: should only be indented 4 spaces.

Done.

http://codereview.chromium.org/11368019/diff/2015/content/browser/renderer_ho...
content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc:109: return
ppapi_host_->OnMessageReceived(msg);
On 2012/11/07 00:18:11, brettw wrote:
> Don't forget to null check this when you add the nulling in
> ~BrowserPpapiHostIMpl

Done.

http://codereview.chromium.org/11368019/diff/2015/content/browser/renderer_ho...
File content/browser/renderer_host/pepper/browser_ppapi_host_impl.h (right):

http://codereview.chromium.org/11368019/diff/2015/content/browser/renderer_ho...
content/browser/renderer_host/pepper/browser_ppapi_host_impl.h:75:
ppapi::host::PpapiHost* ppapi_host_;
On 2012/11/07 00:18:11, brettw wrote:
> You should have a way for this back pointer to be nulled out and do this in
the
> BrowserPpapiHost destructor. This filter may outlive your class, so you should
> always check the pointer nullness before dispatching.

Good catch. Done.

http://codereview.chromium.org/11368019/diff/2015/content/public/browser/cont...
File content/public/browser/content_browser_client.h (right):

http://codereview.chromium.org/11368019/diff/2015/content/public/browser/cont...
content/public/browser/content_browser_client.h:450: virtual void
DidCreatePpapiInstance(int plugin_child_id,
On 2012/11/07 00:18:11, brettw wrote:
> I'm not sure these are used? Are they from a previous patch?

Yep. Thanks.

[brettw, 2012-11-07 00:53:32]

lgtm

[commit-bot: I haz the power, 2012-11-07 00:57:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/11368019/22001

[commit-bot: I haz the power, 2012-11-07 01:47:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/11368019/8029

[bbudge, 2012-11-07 01:47:04]

Fix Windows build error, redundant CONTENT_EXPORT

[commit-bot: I haz the power, 2012-11-07 02:52:42]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[bbudge, 2012-11-07 16:55:06]

Had to replace the typed process iterator with the untyped one because of link
errors. I didn't notice the comment on that.

[commit-bot: I haz the power, 2012-11-07 16:55:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/11368019/4037

[commit-bot: I haz the power, 2012-11-07 19:05:05]

Change committed as 166480